New guest tools ISO for Linux and FreeBSD. Can you help with the tests?

gskger

@stormi Sure, no problem. But there is no /etc/centos-release, only a /etc/centos-release-upstream

[root@freepbx /]# ls /etc/*release* -la
-rw-r--r--. 1 root root  51 Sep  8  2020 /etc/centos-release-upstream
-rw-r--r--. 1 root root 423 Sep  8  2020 /etc/os-release
lrwxrwxrwx. 1 root root  15 May 14 12:26 /etc/redhat-release -> sangoma-release
-rw-r--r--. 1 root root  39 Sep  8  2020 /etc/sangoma-release
-rw-r--r--. 1 root root  39 Sep  8  2020 /etc/sangoma-release-upstream
lrwxrwxrwx. 1 root root  15 May 14 12:26 /etc/system-release -> sangoma-release
-rw-r--r--. 1 root root  34 Sep  8  2020 /etc/system-release-cpe

and cat /etc/centos-release-upstream returns

[root@freepbx /]# cat /etc/centos-release-upstream
Derived from Red Hat Enterprise Linux 7.8 (Source)

Running install.sh when the testing guest tool iso is mounted returns

[root@freepbx Linux]# bash /mnt/Linux/install.sh
Fatal Error: Failed to determine Linux distribution and version.

and xe-linux-distribution returns nothing

[root@freepbx Linux]# /mnt/Linux/xe-linux-distribution
[root@freepbx Linux]#

stormi

Ok, so depending on the version, they sometimes have /etc/centos-release and sometimes not... Can you add this line to xe-linux-distribution before the existing identify_sangoma call and test again? (you'll have to copy the Linux directory from the mounted ISO somewhere else then chmod the file to make it writable)

identify_sangoma /etc/sangoma-release && exit 0

gskger

@stormi Here we go

[root@freepbx Linux]# /tmp/Linux/xe-linux-distribution
os_distro="sangoma"
os_majorver="7"
os_minorver="8"
os_uname="3.10.0-1127.19.1.el7.x86_64"
os_name="Sangoma Linux release 7.8.2003 (Core) "

stormi

@gskger Thanks. I'll fix the script and submit a new RPM.

gskger

@stormi Great! I have snapshots at hand to test FreePBX again with the new testing guest tools iso. No need for testing the other distros again I assume?

stormi

@gskger Well, in theory I'm perfectly capable of breaking the other distros so better be defensive

stormi

xcp-ng-pv-tools-8.2.0-8.xcpng8.2 that should fix FreePBX detection for good (I still don't know why from two people with the exact same version of FreePBX, one has /etc/centos-release and one hasn't...) and hopefully not break anything for other distros... is available in the xcp-ng-testing repo.

gskger

@stormi Installed the new testing guest tools on my two playlab hosts (yum update xcp-ng-pv-tools --enablerepo=xcp-ng-testing) and re-run most of my earlier tests.

From fresh install to testing guest tools on FreePBX 15 (4a-c)

[root@freepbx ~]# bash /mnt/Linux/install.sh
Detected `Sangoma Linux release 7.8.2003 (Core) ' (sangoma version 7).

The following changes will be made to this Virtual Machine:
  * update arp_notify sysctl.
  * packages to be installed/upgraded:
    - xe-guest-utilities-7.20.0-8.x86_64.rpm
    - xe-guest-utilities-xenstore-7.20.0-8.x86_64.rpm

Continue? [y/n] y

Preparing...                          ################################# [100%]
Updating / installing...
   1:xe-guest-utilities-xenstore-7.20.################################# [ 50%]
   2:xe-guest-utilities-7.20.0-8      ################################# [100%]

You should now reboot this Virtual Machine.

From current guest tools to testing guest tools on FreePBX 15 (4b-c)

[root@freepbx ~]# bash /mnt/Linux/install.sh
Detected `Sangoma Linux release 7.8.2003 (Core) ' (sangoma version 7).

The following changes will be made to this Virtual Machine:
  * packages to be installed/upgraded:
    - xe-guest-utilities-7.20.0-8.x86_64.rpm
    - xe-guest-utilities-xenstore-7.20.0-8.x86_64.rpm

Continue? [y/n] y

Preparing...                          ################################# [100%]
Updating / installing...
   1:xe-guest-utilities-xenstore-7.20.################################# [ 33%]
   2:xe-guest-utilities-7.20.0-8      ################################# [ 67%]
Cleaning up / removing...
   3:xe-guest-utilities-7.20.0-1      ################################# [100%]

You should now reboot this Virtual Machine.

Managent agent now is 7.20.0-8, IP is correct and live migration as well as shutdown/reboot worked without an issue.

What I found strange is that for 4b-c (FreePBX) and 3b-c (Centos), I have to reboot the VM to make the new management agent show on the VMs general tab.
I can not remember that I had to do that in my last test and it is not necessary for 1b-c (Debian 10) or 2b-c (Ubuntu 20.04). No need to reboot 1a-c, 2a-c, 3a-c and 4a-c since the management agent is shown correctly right away.

stormi

Thanks @gskger. I think the fact that some b-c transitions require a service restart and others don't may be caused by differences in the post-update scripts that are run. Maybe the DEB packages we made restart the service while the RPM ones don't when the tools are updated.

This might already have been the case before, in Citrix tools, or maybe not. I don't think it's a big deal but it's interesting to note that difference. I'll try to have a look if time permits.

If curious, the package definitions are located at https://github.com/xcp-ng-rpms/xcp-ng-pv-tools/tree/master/SOURCES. debian-* files for debian, and xe-guest-utilities.spec. I think that not restarting the service automatically after an update is default behaviour in RPM world. I don't know about debian's position on this.

gskger

@stormi Perfect! Ok for me ! Any upcoming tests on the new guest tools? Otherwise I would try something else with my playlab, loosing the ability to conduct consistent tests .

stormi

@gskger no upcoming tests on the new guest tools. You can break your lab

gskger

@stormi Nice! Looking forward to when the new gest tools are available.

onyxfire

Just found this thread and tested the updates on the latest updated XCP-ng. They install fine on the Rocky Linux 8.4 GA release but there is a minor issue in the logs when you start the xe daemon:

Started LSB: @BRAND_GUEST@ daemon providing host integration services.

Looks like the branding isn't updated in your RPM.

onyxfire

Also testing Rocky Linux with test tools provided the following results:

Shutdown: OK
Startup: OK
Live Migration: OK

stormi

@onyxfire Thanks for the report. I'll fix it.

stormi

@onyxfire This is now fixed in the latest xcp-ng-pv-tools package in the testing repo. Can you test it?

onyxfire

@stormi Sorry for the delay in testing. This looks to be fixed now. Thanks!

kdm

I'd like to help: I plan to test this against my Mint Linux 20.1 VM and my openmediavault 5 VM.
Question on "3.3 clean shutdown and reboot working". Any time I shutdown XCp-ng, I normally shutdown each VM first. Since I have guest tools installed, should I be able to simply shut down XCP-ng and rely on it to politely shut down my VMs?
Thanks.

stormi

@kdm On a pool with several hosts, xe host-disable uuid=... then xe host-shutdown|reboot uuid=... will evacuate the host towards the other hosts of the pool.

On a single host pool, the same commands will attempt a clean shutdown on each VM.

theAeon

Seems the SUSE Leap 15 assumes the ability to run SysVinit scripts but as of 15.3 (and tumbleweed) insserv-compat is not included and only systemd scripts are supported. It seems there's already a functional systemd script used on RHEL/Fedora, so I have to imagine this is a simple fix of the install.sh.

EDIT: did some pull reqs-should fix MicroOS identification at the least. Could probably handle Tumbleweed the same way. Tried my hand at some systemd rpms too, but god knows if they work.