xo-server: Warning: connect.session() MemoryStore is not designed for a production environment, as it will leak memory, and will not scale past a single process.

MajorTom

Hi. I've just noticed this after usual systemctl status xo-server.service as announced in the XOA banner.

"xo-server: Warning: connect.session() MemoryStore is not designed for a production environment, as it will leak memory, and will not scale past a single process."

The details:

xoa:~# systemctl --no-pager -l status xo-server.service
* xo-server.service - XO Server
   Loaded: loaded (/etc/systemd/system/xo-server.service; enabled; vendor preset: enabled)
   Active: active (running) since Tue 2019-06-04 21:54:45 CEST; 1h 17min ago
 Main PID: 3486 (node)
    Tasks: 16 (limit: 19660)
   CGroup: /system.slice/xo-server.service
           |-3486 node /usr/local/bin/xo-server
           `-3501 /usr/local/bin/node /usr/local/lib/node_modules/xo-server/node_modules/jest-worker/build/workers/processChild.js

Jun 04 21:54:47 xoa xo-server[3486]: Warning: connect.session() MemoryStore is not
Jun 04 21:54:47 xoa xo-server[3486]: designed for a production environment, as it will leak
Jun 04 21:54:47 xoa xo-server[3486]: memory, and will not scale past a single process.
Jun 04 21:54:47 xoa xo-server[3486]: 2019-06-04T19:54:47.621Z - xo:main - [INFO] Setting up / â /usr/local/lib/node_modules/xo-web/dist
Jun 04 21:54:47 xoa xo-server[3486]: 2019-06-04T19:54:47.622Z - xo:plugin - [INFO] register cloud
Jun 04 21:54:47 xoa xo-server[3486]: 2019-06-04T19:54:47.751Z - xo:plugin - [INFO] register telemetry
Jun 04 21:54:47 xoa xo-server[3486]: 2019-06-04T19:54:47.825Z - xo:plugin - [INFO] register xoa
Jun 04 21:54:47 xoa xo-server[3486]: 2019-06-04T19:54:47.939Z - xo:plugin - [INFO] successfully register xoa
Jun 04 21:54:47 xoa xo-server[3486]: 2019-06-04T19:54:47.955Z - xo:plugin - [INFO] successfully register telemetry
Jun 04 21:54:47 xoa xo-server[3486]: 2019-06-04T19:54:47.955Z - xo:plugin - [INFO] successfully register cloud

XOA is stable channel, freshly updated, but I can see the same warning in the logs from the previous version and also in the "latest" channel as well in an other host.

What are the consequences of this memory leak?

borzel

@MajorTom I saw it on my XenOrchestra's and wondered also