Xen-Orchestra Terraform provider and Windows
-
Hi there,
I think we format it in FAT32, so the question would be a Windows question: why the drive isn't detected correctly by Windows? If we knew the MS specs to get a valid FAT32 drive for it, we could maybe modify it, but without knowing, it's hard to do anything…
-
As far as I can tell - XO is creating the cloudconfig on a "VFAT" drive with no partition table. Windows needs a partition table. I think this problem could simply be addressed by adding the creation of a FAT16 partition table - the resulting config drive would still be usable by Linux and additionally by Windows VMs.
FAT32 could be part of the problem - the minimum partition size for FAT32 is 256MB...
https://en.wikipedia.org/wiki/Design_of_the_FAT_file_system#Size_limits
I just ran through this experiment.
Used a terraform plan to deploy a Windows VM.
Used a terraform plan to deply a Linux VM.
On the Linux VM, mounted the "XO CloudConfigDrive" and used fdisk to format the device "/dev/xvdb" (on RHEL in my case) and then added a FAT16 partition.
Here is what I see from fdisk on a "normal CloudConfigDrive
Command (m for help): p Disk /dev/xvde: 10 MiB, 10485760 bytes, 20480 sectors Units: sectors of 1 * 512 = 512 bytes Sector size (logical/physical): 512 bytes / 512 bytes I/O size (minimum/optimal): 512 bytes / 512 bytes Disklabel type: dos Disk identifier: 0x6c302ad6Here is what I see from fdisk on a "Windows-enabled" CloudConfigDrive
Command (m for help): p Disk /dev/xvdc: 10 MiB, 10485760 bytes, 20480 sectors Units: sectors of 1 * 512 = 512 bytes Sector size (logical/physical): 512 bytes / 512 bytes I/O size (minimum/optimal): 512 bytes / 512 bytes Disklabel type: dos Disk identifier: 0x54d69752 Device Boot Start End Sectors Size Id Type /dev/xvdc1 2048 20479 18432 9M 6 FAT16================================
Now, cloudbase-init is able to see the CloudConfig drive and act upon it.
-
Okay if I sum up, "just" creating a FAT16 partition table could do the trick?
-
@julien-f do you remember how hard it was to create a FAT system entirely from XO in Javascript? Do you think it's a lot harder to do that in a partition? (ie creating the partition table, then just one partition with the FAT system inside)
-
@olivierlambert yes, I think that would do it. I can't see any other difference at this point.
-
@olivierlambert https://github.com/vatesfr/xen-orchestra/blob/master/packages/xo-server/src/fatfs-buffer.mjs
I don't remember the details exactly, but it would probably be harder to do it with a partition table.
-
Admittedly, I'm not proficient in this kind of programming, not at all. I tried reading through the code you linked to above and it makes no sense to me. Normally I would try to try fixing this myself, but I just don't have time to invest learning something that's this new to me.
However, I know in a bash script we simply partition the drive and it wouldn't change another thing about subsequent commands, because you're still writing to the drive in the same manner. How is that different in this code?
Your comments make me sad and afraid that you won't take up this challenge to support Windows VMs with cloud-init. I would ask that if you put this off into the future, that you update any blogs or documents to explicitly describe that Windows VMs are excluded from cloud-init compatibility for now, to save anyone else from spending as much time on this as I have.
On a personal note, the news that warm VM migrations from VMware will be built into the GUI for all versions of VMware is then a bittersweet story because it will give us what we need to support migration of our virtualization platforms from VMware. But lack of support for terraform / cloud-init for Windows would mean having to pivot to re-engineer our automation service.
Please advise what we can expect of this bug-squashing in terms of time.
Thanks for all you have done to create and continually improve this platform.
Mike
-
We will discuss this internally ( @marcungeschikts can you add this to the backlog?) and we'll see if it's doable and at which level of difficulty
-
-
-
@rochemike hi,
I did some test on a branch (adding a MBR at the beginning of the cloud init drive) : https://github.com/vatesfr/xen-orchestra/pull/6889 it should fix the windows problem. Can you test it ?
Regards
closed feat(xo-server): add MBR to cloud-init drive #6889
-
@florent Great news! I'm eager to test, but tied up. I hope to get to it within the next 1-2 weeks.
Is there anything special I need to do from my end, or is the patch live?
Mike
-
@rochemike for now the patch lives in a separate branch, it will reach master soon
it will onlatestXOA by the end of the month -
@florent I confess I'm still new to things like "branches" I understand the concepts but am unsure how to go forward. Should I just wait until after the changes go live, or is there some way to test them before then?
-
@rochemike I can help you for this
Do you use XO from the source or a XOA ?
-
@florent XOA
-
@rochemike great, that will be even easier
can you open a support ticket and open a support tunnel ? I will connect and patch your installation
-
@florent ticket opened!
-
@rochemike patch done this morning
-
@rochemike hi mike did you have time to test ?
