@olivierlambert

1. Did you even look at the commit I posted? When I ran this, it was 2 commits behind latest master. Was the commit of you updating a document supposed to make things better? How about the commit to Lite, was that really going to fix anything?

2. Please at least make some effort here, I posted a trace for a reason.

The failing line is this: https://github.com/vatesfr/xen-orchestra/blob/master/%40xen-orchestra/vmware-explorer/esxi.mjs#L211
For some reason, this property is not available on storage.
That code is called from here: https://github.com/vatesfr/xen-orchestra/blob/1942e55f763bd3d74c7cbc3dc1fc4c0ec070414c/packages/xo-server/src/xo-mixins/migrate-vm.mjs#L164

Look at that function for a second, and then re-read what I said in the earlier comment. Why does this function try and do two things? I'm saying it may be a good idea to split this into 2 parts. First, only connect, and then display a page in XO that shows the connection is live, and then after that query the data. This would make things a bit nicer.

More importantly, there needs to be some way for me to help figure out why the data that comes in is not in the format XO is expecting. That way we could solve a problem.

In the future, please don't make several blog posts and a huge thread asking for "feedback" and then tell me "there's little more we can do" when you have done nothing, it doesn't really feel encouraging.

@olivierlambert

1. Did you even look at the commit I posted? When I ran this, it was 2 commits behind latest master. Was the commit of you updating a document supposed to make things better? How about the commit to Lite, was that really going to fix anything?

2. Please at least make some effort here, I posted a trace for a reason.

The failing line is this: https://github.com/vatesfr/xen-orchestra/blob/master/%40xen-orchestra/vmware-explorer/esxi.mjs#L211
For some reason, this property is not available on storage.
That code is called from here: https://github.com/vatesfr/xen-orchestra/blob/1942e55f763bd3d74c7cbc3dc1fc4c0ec070414c/packages/xo-server/src/xo-mixins/migrate-vm.mjs#L164

Look at that function for a second, and then re-read what I said in the earlier comment. Why does this function try and do two things? I'm saying it may be a good idea to split this into 2 parts. First, only connect, and then display a page in XO that shows the connection is live, and then after that query the data. This would make things a bit nicer.

More importantly, there needs to be some way for me to help figure out why the data that comes in is not in the format XO is expecting. That way we could solve a problem.

In the future, please don't make several blog posts and a huge thread asking for "feedback" and then tell me "there's little more we can do" when you have done nothing, it doesn't really feel encouraging.

Hello,

I am not even able to connect. When I enter the credentials for my host and hit connect, I get an error when XO tries to iterate over the data:

esxi.listVms
{
  "host": "10.64.54.4",
  "user": "root",
  "password": "* obfuscated *",
  "sslVerify": false
}
{
  "message": "Cannot read properties of undefined (reading 'perDatastoreUsage')",
  "name": "TypeError",
  "stack": "TypeError: Cannot read properties of undefined (reading 'perDatastoreUsage')
    at file:///opt/xo/xo-builds/xen-orchestra-202303302257/@xen-orchestra/vmware-explorer/esxi.mjs:211:55
    at Array.map (<anonymous>)
    at Esxi.getAllVmMetadata (file:///opt/xo/xo-builds/xen-orchestra-202303302257/@xen-orchestra/vmware-explorer/esxi.mjs:209:31)
    at Api.#callApiMethod (file:///opt/xo/xo-builds/xen-orchestra-202303302257/packages/xo-server/src/xo-mixins/api.mjs:401:20)"
}

Using XO from sources a41037833c960078d8509fd95e01aa0bb5a3670e
ESXi 6.5.0

Regardless of what the issue ends up being, is there maybe a better way of handling the flow? As in, when I click connect, can there be a landing page that says "connected", and allows for partial loading of info? Might be helpful, and will certainly be a better user experience.