CR tag ignored (kind of) in smart backup
-
XO CE, xo-server 5.62.0, xo-web 5.63.0 (doesn't matter, the same was on older versions too)
We have 2 pools (one host XS 7.0.0 in each), cross-pool backups using continuous replication configured on both of them. It means, VMs from pool 1 are replicated to pool 2 and VMs from pool 2 are replicated to pool 1. To avoid replication back, causing loop, we are using exclusions by tag 'Continuous Replication' (default tag XO adds to every replica). Both backup jobs are overlapping in time.
The problem is, some replicas are added to target's backup job and replicating back, despite having 'Continuous Replication' tag. I suspect, that tag is added only after replication is completed, and incomplete VMs are without this tag. This can explain why they are added to backup job. Am I rigt? If so, how can I avoid this? Perhaps this can be considered as XO bug and patched? -
Ping @julien-f
-
Indeed, this is an XO bug, incomplete VMs should be ignored by smart mode, we'll fix it in the next releas.
-
@julien-f Thanks!
-
Thanks again, now CR works as expected!
xo-server 5.64.0
xo-web 5.66.0 -
Hi,
I experienced something similar.
I created a CR job and made it run. It's ~6TB and takes longer that a day (so I had to edit the timeout value). On the receiving end the backup job (using smart mode) started and was also backing up the CR VM (while it was still being transferred for the first time).I checked the new VM and it dit NOT have the CR tag. After the job completed it had the CR tag.
Shouldn't it get the tag as soon as the VM is created to prevent it from begin backuped yet again?I'm using XOCE xo-server 5.68.0 xo-web 5.72.0
-
@julien-f said in CR tag ignored (kind of) in smart backup:
incomplete VMs should be ignored by smart mode
I believe, XO is using some other way to prevent backup loop.
-
It still backupped my VM...
I created a workaround now.
I added a new tag to the source VM (CRbackupBLOCK). This tag is transferred over directly.
The backup job on the receiving server has this tag blocking the VM from being backed up. -
Pinging @julien-f
-
Thank you all for your feedback, I'll fix it ASAP
-
I've created a PR for this issue, feel free to test this branch: https://github.com/vatesfr/xen-orchestra/pull/5341
closed fix(xo-server/{CR,DR}): add tags at VM creation #5341
