Error on Delta Backup - cannot read property "length" of undefined

[clausreinprecht]

Hi folks,

is anybody facing this error? It just comes up on the lastest release - in the merge stage of Delta Backups - I'm seeing this error now on many XO implementations on our clients.

Regards, Claus

[olivierlambert]

Hi,

What do you mean latest release? On XOA, if yes which release channel?

If you are using XO from the sources, double check here: https://xen-orchestra.com/docs/community.html

edit: what is the meaning of "many XO implementations on our clients"?

[vmpr]

I had the same problem in my homelab - xo from sources, installed it the official way from the documentation. updated via git pull --ff-only 3 days ago. the backups are failing with the error message:

  "tasks": [
    {
      "data": {
        "type": "VM",
        "id": "abc2c07e-33e8-97e2-6724-3e69f837d0f7"
      },
      "id": "1617691268721:0",
      "message": "backup VM",
      "start": 1617691268721,
      "status": "failure",
      "tasks": [
        {
          "id": "1617691271853",
          "message": "snapshot",
          "start": 1617691271853,
          "status": "success",
          "end": 1617691328127,
          "result": "74c58079-3e89-53db-a770-6f3b936833b2"
        },
        {
          "id": "1617691328128",
          "message": "merge",
          "start": 1617691328128,
          "status": "failure",
          "end": 1617691328128,
          "result": {
            "message": "Cannot read property 'length' of undefined",
            "name": "TypeError",
            "stack": "TypeError: Cannot read property 'length' of undefined\n    at /home/toor/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/home/toor/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /home/toor/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/home/toor/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/home/toor/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/home/toor/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/home/toor/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/home/toor/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/home/toor/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
          }
        }
      ],
      "end": 1617691344109,
      "result": {
        "message": "Cannot read property 'length' of undefined",
        "name": "TypeError",
        "stack": "TypeError: Cannot read property 'length' of undefined\n    at /home/toor/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/home/toor/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /home/toor/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/home/toor/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/home/toor/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/home/toor/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/home/toor/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/home/toor/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/home/toor/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
      }
    },

I created a new delta backup job and it works now, deleted the old one - but its not the best solution, maybe something is incompatible with the last releases in the master branch to old backup jobs?

hope to help other people with a quick workaround, but hopefully the xoa guys can look into that - great job btw!

cheers, Ringo

[olivierlambert]

Maybe a transient issue on master. That's why, when there's an issue, it's important to check you are on latest master commit and try again

[vmpr]

@olivierlambert yes I thought the same so I updated the code from the master again yesterday but didn't help

[olivierlambert]

Have you tried to create a new job since the update?

[mbt]

I can confirm having the same issue on two XO instances since upgrading to 5.78.2 / 5.80.0

[olivierlambert]

Only master makes sense There's no "release" concept on the sources. Please update to latest master commit, recreate a job and report if you still have the problem

[mbt]

@olivierlambert Hi Olivier,
I updated both instances, recreated the jobs and while backups on one instance now work again, on the other they still fail:

{
  "data": {
    "mode": "delta",
    "reportWhen": "failure"
  },
  "id": "1617829260018",
  "jobId": "72cb10c2-9949-4b9c-9618-33a2de5b0f79",
  "jobName": "customer-weekdays",
  "message": "backup",
  "scheduleId": "8333dbe9-6525-4f4f-a2da-cc6304254e96",
  "start": 1617829260018,
  "status": "failure",
  "infos": [
    {
      "data": {
        "vms": [
          "adbe367b-e33e-66f7-863c-e21ea8fa301a",
          "3837691a-c7c2-3ba9-143f-8afd0eb14f94",
          "cbee81b4-afb8-2773-a92a-dd4b3f83651f",
          "16dd84d4-2455-c293-2529-6311a98ecd46",
          "03037a27-bc51-7cfc-ad64-4146992fc95a",
          "324aa303-4404-20c1-c8f7-686ace47fd3f",
          "5544f33e-5fd9-12e1-ee65-f5849bd7f442",
          "d649555a-c134-fe17-aa68-d49b5ba50edf"
        ]
      },
      "message": "vms"
    }
  ],
  "tasks": [
    {
      "data": {
        "type": "VM",
        "id": "adbe367b-e33e-66f7-863c-e21ea8fa301a"
      },
      "id": "1617829261498:0",
      "message": "backup VM",
      "start": 1617829261498,
      "status": "failure",
      "tasks": [
        {
          "id": "1617829282666",
          "message": "snapshot",
          "start": 1617829282666,
          "status": "success",
          "end": 1617829289768,
          "result": "4815149b-0fb3-8cf3-8ec0-e32d5f3432fc"
        },
        {
          "id": "1617829289768:0",
          "message": "merge",
          "start": 1617829289768,
          "status": "failure",
          "end": 1617829289771,
          "result": {
            "message": "Cannot read property 'length' of undefined",
            "name": "TypeError",
            "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
          }
        }
      ],
      "end": 1617829291965,
      "result": {
        "message": "Cannot read property 'length' of undefined",
        "name": "TypeError",
        "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
      }
    },
    {
      "data": {
        "type": "VM",
        "id": "3837691a-c7c2-3ba9-143f-8afd0eb14f94"
      },
      "id": "1617829291966",
      "message": "backup VM",
      "start": 1617829291966,
      "status": "failure",
      "tasks": [
        {
          "id": "1617829292001",
          "message": "snapshot",
          "start": 1617829292001,
          "status": "success",
          "end": 1617829299739,
          "result": "e095c928-92c3-c085-1ea0-70584e5300e1"
        },
        {
          "id": "1617829299739:0",
          "message": "merge",
          "start": 1617829299739,
          "status": "failure",
          "end": 1617829299739,
          "result": {
            "message": "Cannot read property 'length' of undefined",
            "name": "TypeError",
            "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
          }
        }
      ],
      "end": 1617829301116,
      "result": {
        "message": "Cannot read property 'length' of undefined",
        "name": "TypeError",
        "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
      }
    },
    {
      "data": {
        "type": "VM",
        "id": "cbee81b4-afb8-2773-a92a-dd4b3f83651f"
      },
      "id": "1617829301116:0",
      "message": "backup VM",
      "start": 1617829301116,
      "status": "failure",
      "tasks": [
        {
          "id": "1617829301149",
          "message": "snapshot",
          "start": 1617829301149,
          "status": "success",
          "end": 1617829309295,
          "result": "b34ab48b-4077-0ad8-ea82-8c7233c82db6"
        },
        {
          "id": "1617829309296",
          "message": "merge",
          "start": 1617829309296,
          "status": "failure",
          "end": 1617829309296,
          "result": {
            "message": "Cannot read property 'length' of undefined",
            "name": "TypeError",
            "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
          }
        }
      ],
      "end": 1617829320279,
      "result": {
        "message": "Cannot read property 'length' of undefined",
        "name": "TypeError",
        "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
      }
    },
    {
      "data": {
        "type": "VM",
        "id": "16dd84d4-2455-c293-2529-6311a98ecd46"
      },
      "id": "1617829320279:0",
      "message": "backup VM",
      "start": 1617829320279,
      "status": "failure",
      "tasks": [
        {
          "id": "1617829320312",
          "message": "snapshot",
          "start": 1617829320312,
          "status": "success",
          "end": 1617829333295,
          "result": "1596e20b-e061-df4c-46d3-b2d5cce00094"
        },
        {
          "id": "1617829333295:0",
          "message": "merge",
          "start": 1617829333295,
          "status": "failure",
          "end": 1617829333295,
          "result": {
            "message": "Cannot read property 'length' of undefined",
            "name": "TypeError",
            "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
          }
        }
      ],
      "end": 1617829339414,
      "result": {
        "message": "Cannot read property 'length' of undefined",
        "name": "TypeError",
        "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
      }
    },
    {
      "data": {
        "type": "VM",
        "id": "03037a27-bc51-7cfc-ad64-4146992fc95a"
      },
      "id": "1617829339415",
      "message": "backup VM",
      "start": 1617829339415,
      "status": "failure",
      "tasks": [
        {
          "id": "1617829339440",
          "message": "snapshot",
          "start": 1617829339440,
          "status": "success",
          "end": 1617829343670,
          "result": "65a5a558-c30a-d0d8-5d02-57056bf6f7fc"
        },
        {
          "id": "1617829343671",
          "message": "merge",
          "start": 1617829343671,
          "status": "failure",
          "end": 1617829343671,
          "result": {
            "message": "Cannot read property 'length' of undefined",
            "name": "TypeError",
            "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
          }
        }
      ],
      "end": 1617829344953,
      "result": {
        "message": "Cannot read property 'length' of undefined",
        "name": "TypeError",
        "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
      }
    },
    {
      "data": {
        "type": "VM",
        "id": "324aa303-4404-20c1-c8f7-686ace47fd3f"
      },
      "id": "1617829344954",
      "message": "backup VM",
      "start": 1617829344954,
      "status": "failure",
      "tasks": [
        {
          "id": "1617829344986",
          "message": "snapshot",
          "start": 1617829344986,
          "status": "success",
          "end": 1617829352405,
          "result": "a0e9ca62-3e76-b6d1-cb0c-a3f0e602aded"
        },
        {
          "id": "1617829352405:0",
          "message": "merge",
          "start": 1617829352405,
          "status": "failure",
          "end": 1617829352405,
          "result": {
            "message": "Cannot read property 'length' of undefined",
            "name": "TypeError",
            "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
          }
        }
      ],
      "end": 1617829354244,
      "result": {
        "message": "Cannot read property 'length' of undefined",
        "name": "TypeError",
        "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
      }
    },
    {
      "data": {
        "type": "VM",
        "id": "5544f33e-5fd9-12e1-ee65-f5849bd7f442"
      },
      "id": "1617829354244:0",
      "message": "backup VM",
      "start": 1617829354244,
      "status": "failure",
      "tasks": [
        {
          "id": "1617829354276",
          "message": "snapshot",
          "start": 1617829354276,
          "status": "success",
          "end": 1617829358692,
          "result": "6f1be8c4-4559-35da-e0b7-efc042d9b174"
        },
        {
          "id": "1617829358692:0",
          "message": "merge",
          "start": 1617829358692,
          "status": "failure",
          "end": 1617829358692,
          "result": {
            "message": "Cannot read property 'length' of undefined",
            "name": "TypeError",
            "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
          }
        }
      ],
      "end": 1617829359980,
      "result": {
        "message": "Cannot read property 'length' of undefined",
        "name": "TypeError",
        "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
      }
    },
    {
      "data": {
        "type": "VM",
        "id": "d649555a-c134-fe17-aa68-d49b5ba50edf"
      },
      "id": "1617829359980:0",
      "message": "backup VM",
      "start": 1617829359980,
      "status": "failure",
      "tasks": [
        {
          "id": "1617829360005",
          "message": "snapshot",
          "start": 1617829360005,
          "status": "success",
          "end": 1617829365133,
          "result": "7b152071-5515-80c0-13fc-e390a13592d4"
        },
        {
          "id": "1617829365133:0",
          "message": "merge",
          "start": 1617829365133,
          "status": "failure",
          "end": 1617829365133,
          "result": {
            "message": "Cannot read property 'length' of undefined",
            "name": "TypeError",
            "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
          }
        }
      ],
      "end": 1617829367170,
      "result": {
        "message": "Cannot read property 'length' of undefined",
        "name": "TypeError",
        "stack": "TypeError: Cannot read property 'length' of undefined\n    at /opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:114:31\n    at Zone.run (/opt/xen-orchestra/node_modules/node-zone/index.js:80:23)\n    at /opt/xen-orchestra/node_modules/node-zone/index.js:89:19\n    at Function.fromFunction (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:20:27)\n    at SyncThenable.fulfilledThen [as then] (/opt/xen-orchestra/@xen-orchestra/backups/_syncThenable.js:2:50)\n    at TaskLogger.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:77:10)\n    at Object.run (/opt/xen-orchestra/@xen-orchestra/backups/Task.js:157:17)\n    at DeltaBackupWriter._deleteOldEntries (/opt/xen-orchestra/@xen-orchestra/backups/_DeltaBackupWriter.js:108:17)\n    at Array.<anonymous> (/opt/xen-orchestra/@xen-orchestra/backups/_VmBackup.js:150:70)\n    at Function.from (<anonymous>)"
      }
    }
  ],
  "end": 1617829367170
}

[olivierlambert]

Does it ring any bell @julien-f ?

[julien-f]

Nope, I don't see how this error can occur, are you up to date with master?

[mbt]

At least I think so. I worked with svn for years but that was ages ago and I never got into using git.

root@xo:/opt/xen-orchestra# git rev-parse master
de288a008d83b81ea93d7f45889972028ff9ed6c
root@xo:/opt/xen-orchestra# git branch
* master
root@xo:/opt/xen-orchestra# git fetch --dry-run
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 5 (delta 3), reused 5 (delta 3), pack-reused 0
Unpacking objects: 100% (5/5), done.
From https://github.com/vatesfr/xen-orchestra
   e2515e531..52c4df4e4  ya_host_update_rev -> origin/ya_host_update_rev

[julien-f]

@mbt A simple git pull --ff-only should do the trick.

Anyway, I think I found the issue

[julien-f]

Should be fixed on master, please test and keep me posted

FYI https://github.com/vatesfr/xen-orchestra/commit/8e4c90129e2ce82cd1d4097005048c0564898e72

0 julien-f committed to vatesfr/xen-orchestra

fix(backups/DeltaBackupWriter): dont overwrite prepare/cleanup in constructor

Introduced in e69b6c4dc

[mbt]

@julien-f Hi Julien,

I updated, recreated the backup job and now it works again. Thank you!

[julien-f]

@mbt Great! Thanks for your report and testing