XO5 breaks after defaulting to XO6 (from source)

MajorP93

Hey,

I am not using the XenOrchestraInstallerUpdater script by ronivay but the XO docker container made by the same author: https://github.com/ronivay/xen-orchestra-docker

When using a XO commit after XO 6 became the default all the links to XO 5 do not work anymore.
XO 6 is the default and appears to be working (at least the pages that have been ported to XO 6 already) but when trying to access XO 5 via url/v5 I get infinite loading / spinning wheel.

When following the official documentation steps for making XO 5 default (https://docs.xen-orchestra.com/configuration#making-xo-5-the-default-ui) I get the same issue that was already mentioned in this thread (error "Cannot get /").

By following the official documentation I mean applying the following:

[http.mounts]
'/v6' = '../../@xen-orchestra/web/dist/'
'/' = '../xo-web/dist/'

[http.proxies]
'/v5/api' = 'ws://localhost:9000/api'
'/v5/api/updater' = 'ws://localhost:9001'
'/v5/rest' = 'http://localhost:9000/rest'

I tried this using latest commit (d9fe9b603fa9c8d668fa90486ae12fe7ad49b257).

For now I had to revert to the commit before XO 6 was made the default.

P.S. (in case this is related): I enabled SSL encryption by setting the following in XO configuration:

[http]
redirectToHttps = true

[[http.listen]]
port = 443
autoCert = true
cert = '/cert.pem'
key = '/cert.key'

MathieuRA

@acebmxer Can you provide me with the logs from xo-server at its launch?

MathieuRA

@MajorP93 various fixes have been performed on master.

Your config file should look like this

[http.mounts]
# Uncomment to setup a default version.
# Otherwise, XO5 will be the default for stable channel and XO6 for latest and source
# '/' = '../xo-web/dist/'

'/v5' = '../xo-web/dist/'
'/v6' = '../../@xen-orchestra/web/dist/'

[http.proxies]
# [port] is used to reuse the same port declared in [http.listen.0]
'/v5/api' = '[protocol]//localhost:[port]/api'
'/v5/api/updater' = 'ws://localhost:9001'
'/v5/rest' = 'http://localhost:[port]/rest'

If you are using a different configuration file that overrides the default configuration, please verify that the paths to xo-5 and xo-6 are correct. You can use absolute paths if necessary.

acebmxer

@MathieuRA said in XO5 breaks after defaulting to XO6 (from source):

@acebmxer Can you provide me with the logs from xo-server at its launch?

Here you go. I made the changes you last suggested to me then I did a restart - sudo systemctl restart xo-server

before change-log.txt
after change-log.txt

Let me know if i did that correctly or if you need more information.

MathieuRA

@acebmxer I want logs from the journalctl.
sudo systemctl restart xo-server
sudo journalctl -fu xo-server

acebmxer

@MathieuRA

Again thank you so much for you time trying to assist with this. The script OP has responded and updated the script to work correctly now.

Again thank to all Vates staff for all the hard work you do that goes unnoticed.

MathieuRA

@acebmxer
Perfect.
Thank you all as well! Early testing and feedback are very precious to us.

MajorP93

@MathieuRA said in XO5 breaks after defaulting to XO6 (from source):

@MajorP93 various fixes have been performed on master.

Your config file should look like this
[http.mounts]
# Uncomment to setup a default version.
# Otherwise, XO5 will be the default for stable channel and XO6 for latest and source
# '/' = '../xo-web/dist/'

'/v5' = '../xo-web/dist/'
'/v6' = '../../@xen-orchestra/web/dist/'

[http.proxies]
# [port] is used to reuse the same port declared in [http.listen.0]
'/v5/api' = '[protocol]//localhost:[port]/api'
'/v5/api/updater' = 'ws://localhost:9001'
'/v5/rest' = 'http://localhost:[port]/rest'
If you are using a different configuration file that overrides the default configuration, please verify that the paths to xo-5 and xo-6 are correct. You can use absolute paths if necessary.

Thanks!
I tried your approach but it did not fix the issue.
The maintainer of the Docker container (ronivay) was able to narrow the issue down to users that let XO handle http to https redirection and SSL encryption.

For now I made Xen Orchestra listen on port 80 only and disabled http to https redirection.
I use Traefik as reverse proxy now and let it handle those parts.

With that setup it works without any issues.

Maybe at some point somebody could further investigate wether or not http to https redirection in combination with SSL encryption is broken after XO 6 became the default.

Would be interesting to see if this issue occurs for non-docker users aswell.

acebmxer

@MajorP93

I think ronivay is doing something with Xen Orchestra which is why @mathieura suggestions were not working. I tried to follow his changes in the none docker script but it was above my head. Either way glad he was able to resolve your issues as well.

MathieuRA

@MajorP93 I think I am finally able to reproduce the bug. I will try to fix it

MathieuRA

@MajorP93 can you try this branch? mra-fix-redirect-https It should fix your issue with redirectToHttps=true

MajorP93

@MathieuRA I disabled Traefik and reverted to my old XO config (port 443, ssl encryption, http to https redirection), rebuild the docker container using your branch and tested:

it is working fine on my end now

Thank you very much!

I did not expect this to get fixed so fast!