Sources upgrade - can't restore backups ('invalid parameters')

Tackyone

Hi,

Not been here for a while - all the forums have changed, so hope this is the right place to post...

I recently upgraded my home 'from the sources' xen-orchestra - I was running apparently 'feat: release 5.55.1', I'm now running the latest ('feat: release 5.61.0')

This seems to work - but testing backup restores, I get an "invalid parameters" error popup and the restore doesn't start.

Looking at the error in detail I see:

backupNg.importVmBackup
{
  "id": "604ab8e7-0132-4879-a2e1-b5fcf886ac09/xo-vm-backups/b7e27857-0bf3-24b9-84f9-ed618fbf4531/20210808T032240Z.json",
  "settings": {
    "newMacAddresses": false
  },
  "sr": "0d54ce46-eb09-7515-e8e3-45528b7ebe2d"
}
{
  "code": 10,
  "data": {
    "errors": [
      {
        "code": null,
        "reason": "strict",
        "message": "should not contains property [\"settings\"]",
        "property": "@"
      }
    ]
  },
  "message": "invalid parameters",
  "name": "XoError",
  "stack": "XoError: invalid parameters
    at Object.invalidParameters (/home/xo-user/xen-orchestra/packages/xo-common/src/api-errors.js:21:32)
    at Object.call (/home/xo-user/xen-orchestra/packages/xo-server/src/xo-mixins/api.js:73:18)
    at Api.callApiMethod (/home/xo-user/xen-orchestra/packages/xo-server/src/xo-mixins/api.js:300:19)"
}

Any ideas? - This happens for any backups (that were all done with 5.55.1) - they are all delta backups. I've checked the remote (NFS backup storage) is connected, and ok (and it pasts the 'test' option).

I did have a quick search around but couldn't see any issue with this or similar open etc.

Thanks

Danp

What happens if you run the backup job again? Does the problem still occur afterwards?

jmccoy555

Funnily enough (well not...), I was just having a back up tidyup and am seeing this;

backupNg.deleteVmBackup
{
  "id": "c20a37bc-748d-4320-ac56-53bf97c2f307//xo-vm-backups/2c4beba7-e1b7-0b4c-0165-a12cb7c0fb04/20210713T051224Z.json"
}
{
  "code": -32601,
  "data": "backup.deleteVmBackup",
  "message": "method not found: backup.deleteVmBackup"
}

xo-server 5.81.0
xo-web 5.85.0

Last built a few weeks ago.

edit.... hummm my issue could be proxy related by the looks of it.

Danp

@jmccoy555 This doesn't appear to be related to the OP. However, I would suggest rebuilding using the latest source and then try again.

Tackyone

@danp

Ok - I created a new backup job, for a small VM (again, delta backup) - going to a new test remote.

The backup ran - as it's the first time, it did a full copy as you'd expect, and it completed ok.

I cannot restore it either - shows the same 'invalid parameters' error - and the log details shows the same '"should not contains property ["settings"]"'

Backend server is XCP-ng 8.2

Tackyone

@danp
Hi, don't know if you were suggesting I do the rebuild or @jmccoy555 - but I've tried rebuilding re-checking out - and yarn clean / yarn built et'al - and still have the same error.

Danp

@tackyone Are you able to test this with XOA to check if the error also occurs there?

jmccoy555

Just rebuilt to xo-server 5.81.2 / xo-web 5.86.0

Removing the Proxy from the remote and it looks like everything is good. Restored backup taken in Dec 2019.... so plenty of versions ago, and all is ok.

Backups still work with the Proxy.

Tackyone

@danp Hi - unfortunately not. I don't have access to XOA. I just tried to download the trial / starter edition, which can't restore - and I can't upgrade to the free trial - because I've already had a free trial

Tackyone

@danp I think there's something out of sync somewhere (though I was careful this was a new/fresh clone of git master) - I can't create VM's either (e.g. ""message": "should not contains property ["bypassMacAddressesCheck"]"".

I'll do a completely clean build not upgrade and see if it's still happening...

Tackyone

Ok, full rebuild from nothing seems to have fixed it... Bonus points if someone can suggest how I can copy the settings from the previous instance to this one?

/var/lib/xo-server/data/leveldb doesn't seem to like being copied (even with XO shutdown).

It'd be great to be able to pull the backup jobs over.

Danp

@tackyone Just export the config from the old VM and import into the new one

Tackyone

@danp I'd convinced myself that the 'Export Settings' option didn't work when XO was compiled from sources

I've just tried it now, and it does work - what was happening (literally all this time!) is Safari pops up the tiniest "Popup window blocked" icon in the address bar you've ever seen. Click that - and the download starts

olivierlambert

FYI, you can always ask for another XOA trial when you need it