XO task watcher issue/CR broken

julien-f

@JamfoFL cr-issue was a test branch that I've just removed, please try on master.

JamfoFL

@julien-f OK... I just updated again and there's no change.

It certainly looks like a snapshot is created (I see one attached to the VM right now), but nothing ever progresses. Right now, the job is listed with this status:

[XO] Exporting content of VDI VXCTEST-22-02 Primary (on XCPHOST1) 0%

It's been there for about 10 minutes. I will allow this to continue to run to see if there's ever any progress... but this is usually where thigs jam up and the job never completes.

julien-f

@JamfoFL If you can find the latest commit on which it worked for you, that would be very helpful

One way that you could find the correct commit without checking out every one of them is to use a binary search with git bisect.

First you need to find an older commit that did not exhibit the issue, then you can start the search:

# Move to XO directory
cd xen-orchestra

# Ensure you are up-to-date on `master`
git checkout master
git pull --ff-only

# Tell git to start the search
git bisect start

# Current version is bad
git bisect bad

# Tell git which commit was good
git bisect good <commit id>

# Now that git knows the good and the bad commit, it will select a commit to test

Testing a commit:

# Re-install dependencies and rebuild XO
yarn; yarn build

# Run xo-server
./packages/xo-server/dist/cli.mjs

# Test XO to see if it has the problem

# Interrupt xo-server with Ctrl+C

# If the problem is present:
git bisect bad

# If the problem is absent:
git bisect good

# Continue testing commits until git tells you which commit is the first with the problem, example:
#
# Bisecting: 0 revisions left to test after this (roughly 0 steps)
# [31f850c19c2c2ad5054c292d0f22e9237869dc04] fix(xo-server-transport-email): log async errors

After the search, to go back to the initial state:

git bisect reset

JamfoFL

@julien-f Thank you, Julien-f!

I ran through that procedure (sorry it took so long) and the last commit where everything works as expected was bf51b94. Of course, I could be back to the point where it might need to run all day before one fails, but I was, at least, able to run one of each type of backup on that commit.

Is there any way I can revert my environment back to that commit so I can have the security of backups again? Or should I ride this out while you take a look?

Thanks!

olivierlambert

Just to be sure, if you go on very next commit, like 263c23ae8f1bc6f3f32ab5fa02c3800b29db8d37, then do a git checkout 263c23ae8f1bc6f3f32ab5fa02c3800b29db8d37 and yarn, plus yarn build after, and re-run xo-server with ./packages/xo-server/dist/cli.mjs. Start a backup job and report

JamfoFL

@olivierlambert I think I'm a bit confused. After I finished the testing as @julien-f recommended and ran git bisect reset, it put me back on the very latest commit (at the time). Right now, it shows me on commit 890b46b and nothing is working again.

Is there a way I can revert my current build back to bf51b94 permanently? I would assume that, after that point, I would then use your suggestions moving forward?

Sorry if I'm understanding correctly!

olivierlambert

Latest commit on master branch is 2de9984945a970b7e2273e69c4c89662156d1824.

Are you sure you are on master, right? (do a git branch to so it)

JamfoFL

@olivierlambert Thank you... yes, shortly after I replied, I did figure out how to "roll back" and am currently on commit bf51b945c5348ba76459e603be87416d3415b264, which is the last commit I was on when everything worked. With my XO on that commit, I am now able to run my routine backups and am in the process of doing so! I had no backups due to the error, so I want to get at least one good one for my test machines to make sure I'm covered.

I ran the "git branch" as you asked and can confirm I see two branches listed, master and cr-issue. The "*" was next to master (and it was highlighted in green), so I am assuming that is the current branch I am on.

So... now that everything appears to be working again, are you saying you would like me to run "git checkout 2de9984945a970b7e2273e69c4c89662156d1824" to update to the latest version? Does that have the effect of bypassing all of the commits between the working bf51b and the very latest 2de99? I'd hate to have done all of this and got my backups working only to break them again. I do realize I need to get up-to-date at some point!

Thanks!

olivierlambert

You can't stick forever at a commit "because it works". As a source user, you need to stay up to date on a recent basis, otherwise you might have other issues you can't see at first.

But in your case, your useful contribution in the project can be to check the commit just after the "working one" for you (so the commit just after bf51b94) and see if it still works. If it doesn't, it's certain that the issue is the first faulty commit. It will help @julien-f to find the bug

You can instantly rollback to the previous known commit for you.

If you don't rebuild after a commit change, this won't change anything. You must rebuild every time you change a commit or update to the latest commit!

JamfoFL

@olivierlambert OK... I am happy to help!

Let me take a little time to capture good, working backups of my lab environment so I have that peace of mind, and then I will start applying each of the subsequent commits until I can report the specific commit that starts the issue.

This may take a little time, as I can report when it first happened (on Monday, Feburary 6th) everything did seem to work for several hours after I applied the three commits that were published that day:

2f65a86aa08a8c05de0f5d864994b560f528d364
2a70ebf66711030cf6e277aeabc64037548b9a6b
55920a58a32e01a3ea0b966c8f6f542f835e936a

It wasn't until well into the evening of Monday night when the first CR backups started to fail, and everything seemed to cascade from there. So, I will incrementally apply each commit and will let it run for a day or two (unless if fails sooner, of course). Once I have the definitive commit where things break, I will report that back right away.

Thanks you for all your help!

olivierlambert

Thank you for helping us to track down the issue, this is truly helpful

JamfoFL

OK... just an update. Everything has been working perfectly on bf51b94 for the past few days, so I have just updated to the next commit after that one, 263c23a.

I will continue to monitor and if things keep working, will move to the next commit in line.

julien-f

@JamfoFL Thank you

JamfoFL

@julien-f Everything still working well after the weekend. Switched to commit 2f65a86.

Will report back!

JamfoFL

All still working... have moved up to commit 55920a58a32e01a3ea0b966c8f6f542f835e936a.

JamfoFL

Now on 9f4fce9daa75b418d099928d1ab37a0b2cdd3078...

julien-f

@JamfoFL Thank you for your all your testing

We have fixed a connection issue last Friday, and I'm currently working on additional fixes, I'll let you know as soon as it's available so that you will be able to test latest changes!

JamfoFL

@julien-f Awesome! Thank you for the update.

JamfoFL

@julien-f I just wanted to update and let you know that whatever changes you made fixed the issue for me permanently! I have been able to routinely update since that time and have had no further issues.

Thanks for all of your hard work, Julien-f!