Bonded interface viewing support in XO

TheNorthernLight

@voipdude Agree'd. This would be a nice interface update.

olivierlambert

That's already there. There's an eye button with an hover text: "Show PIFs".

edit: I'm not sure to fully understand what's missing exactly, can you be more specific?

VoipDude

@olivierlambert said in Bonded interface viewing support in XO:

That's already there. There's an eye button with an hover text: "Show PIFs".

edit: I'm not sure to fully understand what's missing exactly, can you be more specific?

In my case, pressing on this button just shows the bond interface and not what makes up the bond. See screenshot:

xo bonds.png

Edit: Sorry, realized that you wanted to understand what it's missing.
For me, it should show what type of bond it is (ex: in my case it's Active-Passive) as well as the physical interfaces that make it up (Ex: in my case bond0 is eth4 and eth5 bonded together).
Even better would be to be able to even edit the bond (ex: change up interfaces in case something fails), but that might be a Xen limitation.

olivierlambert

If you can get this info via xe CLI, then we should have them in XO too

TheNorthernLight

@voipdude said in Bonded interface viewing support in XO:

@olivierlambert said in Bonded interface viewing support in XO:

That's already there. There's an eye button with an hover text: "Show PIFs".

edit: I'm not sure to fully understand what's missing exactly, can you be more specific?

In my case, pressing on this button just shows the bond interface and not what makes up the bond. See screenshot:

Edit: Sorry, realized that you wanted to understand what it's missing.
For me, it should show what type of bond it is (ex: in my case it's Active-Passive) as well as the physical interfaces that make it up (Ex: in my case bond0 is eth4 and eth5 bonded together).
Even better would be to be able to even edit the bond (ex: change up interfaces in case something fails), but that might be a Xen limitation.

At the very least, it would be extremely useful to be able to change the TYPE of bond (its easy to mis-configure this, and its annoying to have to change via CLI).

VoipDude

@olivierlambert

(I have snipped some of the output for brevety)

Yes, so this command shows the interfaces that are participating in the bond:

#  xe bond-list
uuid ( RO)      : 5f470b0a-f59e-5c34-69a5-4676719da6d6
    master ( RO): 8d0b83b2-4336-c7a5-f84f-be0d6a49064f
    slaves ( RO): 3598380c-3da3-c096-7a84-2c4ac2b280ee; 7188d716-cf0a-4e34-5ab1-5ddae4e6fe28

But then we need to find out which UUID corresponds to which interface by doing a pif-list:

# xe pif-list
uuid ( RO)                  : 8d0b83b2-4336-c7a5-f84f-be0d6a49064f
                device ( RO): bond0
    currently-attached ( RO): true
                  VLAN ( RO): -1
          network-uuid ( RO): f5f7ee91-dcc9-104e-c696-1e74d7ddedb1

uuid ( RO)                  : 3598380c-3da3-c096-7a84-2c4ac2b280ee
                device ( RO): eth4
    currently-attached ( RO): false
                  VLAN ( RO): -1
          network-uuid ( RO): 192daa64-2df8-41a3-9849-8f403104b3fe


uuid ( RO)                  : 7188d716-cf0a-4e34-5ab1-5ddae4e6fe28
                device ( RO): eth5
    currently-attached ( RO): false
                  VLAN ( RO): -1
          network-uuid ( RO): 4f7a5c61-9bd6-dbb5-b34a-3bfe46ced469

So we can see eth4 and eth5 are part of bond0.

I then can find out what kind of bond it is with this command:

# ovs-appctl bond/list
bond	type	recircID	slaves
bond0	active-backup	0	eth4, eth5

Thanks,

olivierlambert

Sadly, we won't have access to ovs command. But maybe the whole bond record?

VoipDude

@olivierlambert Yup, you're right! This command gives the bond type:

# xe bond-param-list uuid=5f470b0a-f59e-5c34-69a5-4676719da6d6
uuid ( RO)               : 5f470b0a-f59e-5c34-69a5-4676719da6d6
             master ( RO): 8d0b83b2-4336-c7a5-f84f-be0d6a49064f
             slaves ( RO): 3598380c-3da3-c096-7a84-2c4ac2b280ee; 7188d716-cf0a-4e34-5ab1-5ddae4e6fe28
               mode ( RO): active-backup
         properties (MRO): 
      primary-slave ( RO): 3598380c-3da3-c096-7a84-2c4ac2b280ee
           links-up ( RO): 2
    auto-update-mac ( RO): true

olivierlambert

Okay so could you recap what info you'd like, from which source (xe command) and where?

VoipDude

@olivierlambert

In the interfaces list, each interface that is bonded should have this info:

The bond device name and network
This is already present today in XO, so no changes here.
The type of bond
Derived from xe bond-list and then xe bond-param-list uuid=XXXX
The underlying interfaces (ex: eth0, eth1) that are participating in the bond
Derived from xe bond-list and then the slave UUIDs references to the device names from xe pif-list

In terms of "where", it should be in either Pool > Network or Pool > Host > Network (or both, still not sure the difference between viewing networks in the pool or host)

And as @TheNorthernLight mentioned, it would be great to be able to modify bonds (ex: remove or add or change the underlying interfaces that are in the bond). I don't have XenCenter handy to test if that's a thing, it might be not be possible to modify existing bonds.

Thanks!

olivierlambert

@fohdeesha what do you think? If it sounds reasonable, we should create a Github issue with this

fohdeesha

@olivierlambert I think the request makes sense, it would be really helpful to see at a quick glance what type of bond it is and what are the bond members (especially for support)