Why changing objects in resource set wipe limits ???

Kptainflintt

Hi,

I have a big trouble with playing with xo-cli to update my resource sets.

First, it's really annoying that templates and tags assigned to them aren't update (I want that user "X" cans use all tamplates with "X" tags; I tag a new template, I have to add manually it to resource set...).

Whatever, I build a script who list object, list taggued templates and with resourceSet.set "rebuild" objects array.

What a surprise when I realize that my new template is here, but all of my limits aren't!
So, to see if it's my script which blow away quotas, I test manually on one resource set, it's the same.

For exemple :

{
  "id": "h-PSp-FzCb0",
  "ipPools": [],
  "limits": {
    "cpus": {
      "total": 6,
      "usage": 1
    },
    "memory": {
      "total": 17179869184,
      "usage": 2147483648
    },
    "disk": {
      "total": 80530636800,
      "usage": 17179869184
    },
    "vms": {
      "usage": 1
    }
  },

I launch

xo-cli resourceSet.set id="h-PSp-FzCb0" objects=json:"["71359f87-2297-a2d9-1236-77ebfcbe71eb","74f92165-9f40-a6b0-26e2-6377409d3911","92751eb2-0007-fa22-9001-1b08db171145","dd467579-027a-21a7-5c81-1a396312befb","89ef16d0-9fc6-3bb0-8161-37dc69e64b3b","94f4a9be-5614-9a2b-a389-d0b2c8228b60"]"

And tadaaa !

limits: {"cpus":{"usage":1},"memory":{"usage":2147483648},"disk":{"usage":17179869184},"vms":{"usage":1}}

Is there anything that I'm missing ??

lsouai-vates

@Kptainflintt Hey! XO team dev is doing a fix on it: https://github.com/vatesfr/xen-orchestra/pull/8979

FYI @pdonias

pdonias opened this pull request in vatesfr/xen-orchestra

closed fix(xo-server/resource-sets): only edit limits if `limits` is passed #8979

Kptainflintt

Update : same thing when adding or changing "tags" field.

olivierlambert

Hi,

That would be helpful to know on which XO version you are running first.

Kptainflintt

@olivierlambert Hi,

I use xo from sources. Update two weeks ago.

From CHANGELOG :

@vates/types 1.10.0
@xen-orchestra/web-core 0.27.0
@xen-orchestra/rest-api 0.14.0
@xen-orchestra/web 0.25.0
xo-server 5.185.0

Thank you

olivierlambert

First, you need to update to the latest commit on Master, it's important to be sure in case something changed since then. Cf https://docs.xen-orchestra.com/community#report-a-bug

Kptainflintt

Indeed, I have 39 commits behind...

I can't do it now, as I have several users working on it.

I'll do this before next week, I come back if it's changing something.

olivierlambert

Keep us posted when you are on master, then we'll try to reproduce the issue when we can.

Kptainflintt

@olivierlambert

Hi,

Update was made now to last master branch (and big tanks to REST API doc integration by the way).

Working on a testing resource set.

Before :

xo-cli resourceSet.get id="h-PSp-FzCb0"
{
  id: 'h-PSp-FzCb0',
  ipPools: [],
  limits: {
    cpus: { total: 6, usage: 2 },
    disk: { total: 80530636800, usage: 34359738368 },
    disks: { usage: 2 },
    memory: { total: 12884901888, usage: 3221225472 },
    vms: { usage: 2 }
  },
  name: 'resource-test',
  objects: [
    '71359f87-2297-a2d9-1236-77ebfcbe71eb',
    '74f92165-9f40-a6b0-26e2-6377409d3911',
    '92751eb2-0007-fa22-9001-1b08db171145',
    'dd467579-027a-21a7-5c81-1a396312befb'
  ],
  shareByDefault: false,
  subjects: [ '6ddaf1a0-c440-4539-8634-c00a078aef78' ],
  tags: [ 'test' ]
}

Then, applying new object array :

xo-cli resourceSet.set id="h-PSp-FzCb0" objects=json:'["71359f87-2297-a2d9-1236-77ebfcbe71eb","74f92165-9f40-a6b0-26e2-6377409d3911","92751eb2-0007-fa22-9001-1b08db171145","dd467579-027a-21a7-5c81-1a396312befb","89ef16d0-9fc6-3bb0-8161-37dc69e64b3b","94f4a9be-5614-9a2b-a389-d0b2c8228b60"]'

After :

xo-cli resourceSet.get id="h-PSp-FzCb0"
{
  id: 'h-PSp-FzCb0',
  ipPools: [],
  limits: {
    cpus: { usage: 2 },
    disk: { usage: 34359738368 },
    disks: { usage: 2 },
    memory: { usage: 3221225472 },
    vms: { usage: 2 }
  },
  name: 'resource-test',
  objects: [
    '71359f87-2297-a2d9-1236-77ebfcbe71eb',
    '74f92165-9f40-a6b0-26e2-6377409d3911',
    '92751eb2-0007-fa22-9001-1b08db171145',
    'dd467579-027a-21a7-5c81-1a396312befb',
    '89ef16d0-9fc6-3bb0-8161-37dc69e64b3b',
    '94f4a9be-5614-9a2b-a389-d0b2c8228b60'
  ],
  shareByDefault: false,
  subjects: [ '6ddaf1a0-c440-4539-8634-c00a078aef78' ],
  tags: [ 'test' ]
}

Same result if I add/change "tags" field.

olivierlambert

@lsouai-vates we should try to reproduce and if we can, to fix it ASAP. Thanks!

lsouai-vates

@olivierlambert I am asking XO Team about this issue.

lsouai-vates

@Kptainflintt Hey! XO team dev is doing a fix on it: https://github.com/vatesfr/xen-orchestra/pull/8979

FYI @pdonias

pdonias opened this pull request in vatesfr/xen-orchestra

closed fix(xo-server/resource-sets): only edit limits if `limits` is passed #8979

Kptainflintt

@lsouai-vates

Nice ! Thank you!

olivierlambert

More than working on it, the patch is merged on master, so you can already use it now

Kptainflintt

@olivierlambert

Yes, I saw it !

Just finish update, testing tomorrow !

Thank to all the team

lsouai-vates

@Kptainflintt you are welcome We are always delighted when we can quickly unblock a user!
Have a good day and don't hesitate to come back if you have other issues in the future.