Health Check Failing After Recent XOCE Update

stevewest15

Xen Orchestra, commit 0f00c
Master, commit 0f00c

n lts: v20.10.0 (with npm 10.2.3)
nodejs: v12.22.5

Hi,

XO backups have been working fine but after updating XCP 8.2 to 8.2.1 and updating XOCE to the latest build, the nightly backups are all failing the health check with the error "healthCheckVm.add_tag is not a function":

          "result": {
            "message": "healthCheckVm.add_tag is not a function",
            "name": "TypeError",
            "stack": "TypeError: healthCheckVm.add_tag is not a function\n    at file:///opt/xen-orchestra/@xen-orchestra/backups/_runners/_writers/_MixinXapiWriter.mjs:61:33\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"

I'm unsure if the XCP update or the XOCE recent update is causing the above error.

I'm wondering if it is safe to revert XOCE VM to an older version or will that break something w/ XCP?

Thank you,

SW

julien-f

Fixes https://github.com/vatesfr/xen-orchestra/commit/7780cb176a7e345c96fa0b660322c05349385892

Thank you for report

olivierlambert

Hi,

You should stick with the right version of Node before anything: https://xen-orchestra.com/docs/installation.html#packages-and-pre-requisites

Danp

Hi... this may not have any effect, but you should try it with Node 18 since that is the supported version at this time.

olivierlambert

stevewest15

@olivierlambert Thank you for assistance! I have updated nodejs to v18.19.0 and ran a quick backup test and still getting the same error (see below):

{
  "data": {
    "mode": "delta",
    "reportWhen": "always"
  },
  "id": "1704403800003",
  "jobId": "bff2ddd9-42c4-4e2f-9cbf-d1677c4722f7",
  "jobName": "Test Backup",
  "message": "backup",
  "scheduleId": "86086afa-89b4-4c97-b81f-f5b84bfd0de8",
  "start": 1704403800003,
  "status": "failure",
  "infos": [
    {
      "data": {
        "vms": [
          "605507d7-29cc-acee-176a-2e26a3726d39"
        ]
      },
      "message": "vms"
    }
  ],
  "tasks": [
    {
      "data": {
        "type": "VM",
        "id": "605507d7-29cc-acee-176a-2e26a3726d39",
        "name_label": "Email-Relay"
      },
      "id": "1704403803299",
      "message": "backup VM",
      "start": 1704403803299,
      "status": "failure",
      "tasks": [
        {
          "id": "1704403803307",
          "message": "clean-vm",
          "start": 1704403803307,
          "status": "success",
          "end": 1704403803362,
          "result": {
            "merge": false
          }
        },
        {
          "id": "1704403803373",
          "message": "snapshot",
          "start": 1704403803373,
          "status": "success",
          "end": 1704403806203,
          "result": "b41c174e-511d-69cb-800d-c5d98c806fb2"
        },
        {
          "data": {
            "id": "45ff0925-797b-43dd-a95c-7e298c61ad02",
            "isFull": true,
            "type": "remote"
          },
          "id": "1704403806213",
          "message": "export",
          "start": 1704403806213,
          "status": "success",
          "tasks": [
            {
              "id": "1704403807469",
              "message": "transfer",
              "start": 1704403807469,
              "status": "success",
              "end": 1704403945962,
              "result": {
                "size": 9496147968
              }
            },
            {
              "id": "1704403946008",
              "message": "health check",
              "start": 1704403946008,
              "status": "success",
              "tasks": [
                {
                  "id": "1704403946082",
                  "message": "transfer",
                  "start": 1704403946082,
                  "status": "success",
                  "end": 1704404004994,
                  "result": {
                    "size": 9496147456,
                    "id": "6a6770c4-52f9-440b-5fd6-9bd7decc3930"
                  }
                },
                {
                  "id": "1704404004994:0",
                  "message": "vmstart",
                  "start": 1704404004994,
                  "status": "success",
                  "end": 1704404030700
                }
              ],
              "end": 1704404032136
            },
            {
              "id": "1704404032136:0",
              "message": "clean-vm",
              "start": 1704404032136,
              "status": "success",
              "end": 1704404032158,
              "result": {
                "merge": false
              }
            }
          ],
          "end": 1704404032159
        },
        {
          "data": {
            "id": "349e7130-da43-6550-e7c0-aa0a84102e0f",
            "isFull": true,
            "name_label": "Local storage",
            "type": "SR"
          },
          "id": "1704403806214",
          "message": "export",
          "start": 1704403806214,
          "status": "failure",
          "tasks": [
            {
              "id": "1704403807467",
              "message": "transfer",
              "start": 1704403807467,
              "status": "success",
              "end": 1704403944794,
              "result": {
                "size": 9496147968
              }
            },
            {
              "id": "1704403946008:0",
              "message": "health check",
              "start": 1704403946008,
              "status": "failure",
              "tasks": [
                {
                  "id": "1704403946078",
                  "message": "copying-vm",
                  "start": 1704403946078,
                  "status": "success",
                  "end": 1704404030703,
                  "result": "OpaqueRef:3029e1b8-507e-436d-9634-d4e24b5e82c2"
                }
              ],
              "end": 1704404031113,
              "result": {
                "message": "healthCheckVm.add_tag is not a function",
                "name": "TypeError",
                "stack": "TypeError: healthCheckVm.add_tag is not a function\n    at file:///opt/xen-orchestra/@xen-orchestra/backups/_runners/_writers/_MixinXapiWriter.mjs:61:33\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
              }
            }
          ],
          "end": 1704404031113,
          "result": {
            "message": "healthCheckVm.add_tag is not a function",
            "name": "TypeError",
            "stack": "TypeError: healthCheckVm.add_tag is not a function\n    at file:///opt/xen-orchestra/@xen-orchestra/backups/_runners/_writers/_MixinXapiWriter.mjs:61:33\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
          }
        }
      ],
      "end": 1704404032159
    }
  ],
  "end": 1704404032159
}

Thank you again for your assistance!

SW

Danp

@stevewest15 said in Health Check Failing After Recent XOCE Update:

healthCheckVm.add_tag

I could be wrong here, but I think this is supposed to be healthCheckVm.add_tags

stevewest15

@Danp Thanks! So is this a bug or did I fail to make some changes after updating that's now causing these errors?

Danp

@stevewest15 I suspect that it is a bug that was recently introduced in this commit. Maybe @julien-f will be able to confirm for us.

fataugie

I'm seeing the exact same issue. Also, when I updated to the latest build a few minutes ago...when I go into the main Backup overview page, all the jobs are there, but the schedules are missing, the area is just blank. I have to roll back to a previous build

olivierlambert

@julien-f is back this afternoon, he'll take a look ASAP Thanks for the report!

julien-f

Fixes https://github.com/vatesfr/xen-orchestra/commit/7780cb176a7e345c96fa0b660322c05349385892

Thank you for report

stevewest15

@julien-f Thank you! That appears to fix the error. Greatly appreciate your help and @olivierlambert.