Alert: Control Domain Memory Usage
-
I'm going to build a driver package that only has the patch that is thought to fix the memory issue and let everyone here test it. If the results are good, then it will become an official update.
-
@stormi
The 2 servers have been reinstalled with an up to date 8.2. They host each 2 VMs that are doing the same thing (~100Mb/s of netdata stream).The right one has the 5.9.4-1.xcpng8.2, the left one has 5.5.2-2.xcpng8.2.
The patch seem to be OK for me.
-
Announcement
Here's an updated
ixgbedriver package that is meant as an update candidate without updating to a higher version. If need all feedback we can get on this one, because this is the candidate for the official fix as would be delivered to everyone. Of course theintel-igb-altwill remain available for those who need a more recent driver, and I even moved it to theupdatesrepository so that one doesn't need to add--enablerepo=xcp-ng-testingto install it anymore.To test the official update candidate on XCP-ng 8.1 or 8.2.
- If you had previously installed
intel-ixgbe-alt:yum remove intel-ixgbe-alt -y- Check that the
/lib/modules/4.19.0+1/override/ixgbe.kofile was properly deleted. I've seen, once, a situation where a .ko file from an-altpackage wasn't deleted, so I'm being cautious here and ask you to report you see that it is still present. In theory, this is impossible, but as I've seen it once I don't know anymore
- Run
depmod -a
- Update the
intel-ixgbepackage from the testing repo:yum update intel-ixgbe --enablerepo=xcp-ng-testing - Reboot
Note: I'm not 100% sure that I picked the right patch, nor that this patch alone is sufficient.
- If you had previously installed
-
@stormi I have installed intel-ixgbe 5.5.2-2.1.xcpng8.2 on my server s0267. Let's wait a some days to check if the memleak is solved by this patch.
-
@stormi
It seems to be good here!
-
So we found the good patch
That was a really tricky issue to find! -
Once again, an issue that was present in vendor drivers but not in the mainline kernel. It's becoming harder and harder to trust vendor drivers. But that's what they require for support...
-
Our Citrix ticket has been worked and they concluded that the NIC driver is to blame here as well. They had us collect debug info using:
/opt/xensource/libexec/xen-cmdline --set-dom0 page_owner=onThey then confirmed the memory leak was from the NIC driver. They are intending to release a public hotfix for this issue.
-
Nice to see Citrix are also getting to the same conclusions
edit: thanks @fasterfourier for your feedback!
-
Official Citrix update has been posted: https://support.citrix.com/article/CTX306529
-
\o/
What I still find really weird is the fact we had report of the issue far longer before Citrix. And we had roughly 10 people affected while Citrix got only 1 report
-
Probably plenty of Citrix customers were affected, but they would rather reboot on schedule than spend months working through the support process
-
haha that might be the answer indeed…
-
Hello,
Does this fix has been released or is to be released ?
-
@jcastang It is being tested and you can join the effort:
yum update intel-ixgbe --enablerepo=xcp-ng-testing. The results are very good, I just want a bit more feedback. -
@stormi Ok, I will update one of our pools and get some results.
-
@delaf Can you point me the tool you are using to get memory graphs ? (I want to check my upgraded pool).
I was searching in Advance live Telemetry with no luck. -
Netdata will only give you the last hour.
If you want longer metrics, you need to send the data in Prometheus/Grafana.
-
@jcastang we are using a netdata/prometheus/grafana stack.
@olivierlambert you can change the retention method and keep much more data on netdata. There is also (since netdata 1.18 i think) a dbengine that allows you to store data on disk.
-
PS: we are not using the netdata config from "Advanced telemetry": we are installing our own netdata config.
