Backups silently fail with invalid XO Proxy License

NielsH

Hello,

We've been fiddling / testing a bit with XO Proxies and because of this it seems we now don't have a valid XO Proxy license anymore. That's fine and something we need to fix.

However, due to this backups that use the Proxy now silently fail and I think that's unwanted behaviour.
The backups that use this proxy will now say the backup task was Successful and only took a few seconds. Transfer size is 0 (not shown).

When we click the backup job to show details the modal is empty and the logs copy to:

{
  "data": {
    "mode": "delta",
    "reportWhen": "never"
  },
  "id": "1630274400013",
  "jobId": "3510d252-2d42-41e9-9186-920d90e5af66",
  "jobName": "<VM NAME>",
  "message": "backup",
  "proxyId": "f89a22b8-df0e-4ba2-be69-e5c1f366b707",
  "scheduleId": "4de0d79b-f741-4514-bf48-ab1d706bf8e5",
  "start": 1630274400013,
  "status": "success",
  "end": 1630274400182
}

When we log in on the XO Proxy Appliance this is shown in the xo-proxy service log:

Aug 29 18:00:00 xoa xo-proxy[444]: 2021-08-29T22:00:00.182Z xo:proxy:api WARN ndJsonStream, fatal error {
Aug 29 18:00:00 xoa xo-proxy[444]:   error: Error: no valid proxy license
Aug 29 18:00:00 xoa xo-proxy[444]:       at file:///usr/local/lib/node_modules/@xen-orchestra/proxy/src/app/mixins/backups.mjs:111:19
Aug 29 18:00:00 xoa xo-proxy[444]:       at processTicksAndRejections (internal/process/task_queues.js:95:5)
Aug 29 18:00:00 xoa xo-proxy[444]: }

I would expect the backup job status to be "Failed" when this happens so we are aware of this issue. Now it is "Successful" which will cause us to be in for a nasty surprise had we not seen this on time and needed a backup.

Could this behaviour be changed?

julien-f

@nielsh Hey, not it's not lost yet

We'll try to fix this quick.

olivierlambert

Pinging @julien-f

NielsH

@olivierlambert said in Backups silently fail with invalid XO Proxy License:

Pinging @julien-f

Hi Olivier, @julien-f - just checking to make sure this isn't lost.

Cheers,
Niels

olivierlambert

@julien-f isn't actively monitoring the forum, that's why a support ticket would be preferable in your case

julien-f

@nielsh Hey, not it's not lost yet

We'll try to fix this quick.

julien-f

This has been finally fixed in master, it will be released next week

NielsH

@julien-f Thanks!