Xen Orchestra & XO Lite PWA Manifest
-
julien-f olivierlambert I'm currently looking into producing a PWA manifest for XO and XO Lite. Having enquired about it in the past, though I would like for you to place in the appropriate folders of the Xen Orchestra repository a set of of appropriately coloured icons, of various sizes ranging from 48x48 to 512x512 and a SVG based one. Also in possibly in formats like PNG, WebP and SVG.
The manifest is going to be needing these to provide the necessary icons in the appropriate places.
Also please mention whether in a forum reply whether the icons are masked, non-masked and/or maskable etc.
The icons are what is going to be used by the manifest are representation of XO and XO Lite appropriately. They need to be of various sizes as their going to be graphical image based, for cross platform purposes and to handle different screen sizes.
-
Hmm it's not for me but probably more for the XO Web team. Adding pdonias in the loop
-
-
pdonias I have done a fairly simple manifest for XO: Lite using the favicon.svg in the lite/src/assets folder. Though don't know if this will be alright however haven't added the colour theming stuff, as this would be better handled by graphical artists. As I'm more of a code and text type person, though the basics are there. It will require the insertion of a line of html code in <head></head> to reference it:-
<link rel="manifest" href="/manifest.json">
How would you like to me to send it so it can be looked at and updated if required for review?
I'm waiting for or looking for icons which can be used with XO (XOA) which can be in it's manifest, as currently there aren't any suitable ones. So could one please be added based on the new design identity please?
-
pdonias I have opened a PR for the initial PWA Manifest of XOLite.
https://github.com/vatesfr/xen-orchestra/pull/7291
closed feat(lite): introduce PWA manifest #7291
-
pdonias I'm currently waiting for https://github.com/vatesfr/xen-orchestra/pull/7309 to be merged. As it contains the icon which will be used for my contribution to Xen Orchestra.
Please inform me when this merge will be completed as it's a requirement for my contribution to Xen Orchestra.
closed feat(xo6): introducing `@xen-orchestra/web` #7309
-
pdonias Now preparing my next contribution to the project in the form of the second PWA manifest. This time for use with Xen Orchestra.
-
pdonias Prepared my next contribution to this project in this case on the Xen Orchestra side.
-
Thank you @john-c! We need to make a few changes first, we'll take care of your PR right after that
-
pdonias said in Xen Orchestra & XO Lite PWA Manifest:
Thank you @john-c! We need to make a few changes first, we'll take care of your PR right after that
As a result of taking such a long time to get around to reviewing and merging my PR. The base for my contribution got really out of sync so I had to discard the changes and rebase. This meant the PR got closed a new one was needed. The Old PR with branch was really out of sync and with several lots of conflicts.
https://github.com/vatesfr/xen-orchestra/pull/7445
So please do this new one during today or tomorrow so that the rebasing isn't needed again!
closed xo-web Initial PWA manifest for Xen Orchestra 6 #7445
