Can't disable enabled errored server

Andrew

With XO master commit 4c8c34c you can no longer disable an enabled server that has an error (like connection refused or unreachable). It just logs an error "incorrect state". It should allow an enabled (but errored) server to be disabled.

{
  "id": "11671b5d-7f21-4eeb-b06d-e548696ac30b"
}
{
  "code": 25,
  "data": {
    "actual": "disconnected",
    "expected": [
      "connected",
      "connecting"
    ],
    "object": "11671b5d-7f21-4eeb-b06d-e548696ac30b",
    "property": "status"
  },
  "message": "incorrect state",
  "name": "XoError",
  "stack": "XoError: incorrect state
    at incorrectState (/opt/xo/xo-builds/xen-orchestra-202505191104/packages/xo-common/api-errors.js:26:11)
    at XenServers.disconnectXenServer (file:///opt/xo/xo-builds/xen-orchestra-202505191104/packages/xo-server/src/xo-mixins/xen-servers.mjs:541:19)
    at Xo.disable (file:///opt/xo/xo-builds/xen-orchestra-202505191104/packages/xo-server/src/api/server.mjs:136:3)
    at Task.runInside (/opt/xo/xo-builds/xen-orchestra-202505191104/@vates/task/index.js:175:22)
    at Task.run (/opt/xo/xo-builds/xen-orchestra-202505191104/@vates/task/index.js:159:20)
    at Api.#callApiMethod (file:///opt/xo/xo-builds/xen-orchestra-202505191104/packages/xo-server/src/xo-mixins/api.mjs:469:18)"
}```

Andrew

Forgot to tag someone... @olivierlambert @florent @MathieuRA

MathieuRA

Hi, I will fix it ASAP. Thanks

MathieuRA

PR: https://github.com/vatesfr/xen-orchestra/pull/8599

MathieuRA opened this pull request in vatesfr/xen-orchestra

closed fix(xo-server/xen-server): fix disabling an enabled but disconnected server #8599

Andrew

@MathieuRA For this issue, fix-server-connect works for me. Thanks.