Manual snapshots retention
-
@flakpyro said in Manual snapshots retention:
@olivierlambert I wonder if it would be beneficial to show all snapshots older than 30 days not just ones not created by an automated process. For example what happens if a XO backup job runs, creates a snapshot but the process is interrupted and the job fails. Will the next time the job runs clean up the previous failed jobs snapshot or is there a chance a snapshot could be left behind?
Garbage collection should be handling this...
-
In theory there's no such thing as XO checks. Now for the feature request, I prefer the idea of showing manual leftovers and leave the admin to decide what to do with it
-
you say here that this feature is implemented, but i don't see new menu. ec782
-
I think the dev working on it had personal issues few days before the release, so at worst it will be there in a patch release or in 5.106. There's so much things in the pipe, it's possible sometimes they aren't shipped on D-day. But it will be there finally
-
@olivierlambert haha, i'm watching you)
-
Merged. Works as intented, thank you.
-
T Tristis Oris marked this topic as a question on
-
T Tristis Oris has marked this topic as solved on
-
i found something to remove. Need to change text here, it too scary.
-
@Tristis-Oris I had the SAME thing today. The message scared me for 1min before I hit go.......
-
Hi,
I'm not sure to understand the issue. Removing those old snapshots makes you nervous because on the message telling you if you remove it the data associated with it will be remove? Or maybe it's just a phrasing thing? Like all "VM SNAPSHOTS" will be removed instead of VM only?
-
@olivierlambert "delete vm" "ALL vm disks will be removed" that wrong at least.
Yes, need to change it to snapshots. -
Why it's wrong? All the VM disks for this VM will be removed.
Remember: there's no "snapshot" object, it's only a VM with "is a snapshot: true".
-
@olivierlambert But on my side VM it's VM. Snapshot it's something else)
And not "all", "selected" sounds better. -
@olivierlambert !Delete VMs ->Delete VM Snapshots
delete 7 vms -> delete 7 VM snapshots
I you don't know as it is it scares you. Did me!
-
Yes, I get it. But that explains why the message is generic for VM removal (because it's the same that's a VM with snapshot true or false).
I agree this could improved, but I'm not sure this worth the effort vs moving forward on XO 6/XO Lite
-
@olivierlambert but on vm page it works as should.
-
@olivierlambert Now I know that there is no risk
BUT it got me scared definitely. And probably will others.Also it's just a changing of a string so it should be easy.
-
Not necessarily that easy, especially on a "legacy" code base, I truly wonder if we should invest some time on this instead of XO 6?
-
@olivierlambert Your call Β―_(γ)_/Β―
-
@olivierlambert release this year? (c)
-
I don't understand the question
XO 6 is already here and takes 90% of our XO front team load. Anything on XO 5 will slow down the number of features available in XO 6.
