Manual snapshots retention
-
If we just want to display it in "Health view" that would be better to have at least a default value we all agree on
-
@olivierlambert 30 days seems OK to me.
-
@olivierlambert well, 30 days is a super maximum for any real needs to restore anything.
-
-
@olivierlambert I added a response in the hopes that it clarifies the end-goal.
-
@olivierlambert I wonder if it would be beneficial to show all snapshots older than 30 days not just ones not created by an automated process. For example what happens if a XO backup job runs, creates a snapshot but the process is interrupted and the job fails. Will the next time the job runs clean up the previous failed jobs snapshot or is there a chance a snapshot could be left behind?
-
@flakpyro true, sometimes that happens and they will never be deleted.
I'm don't remember, but maybe such snaspshots not visible as orphaned. -
@flakpyro said in Manual snapshots retention:
@olivierlambert I wonder if it would be beneficial to show all snapshots older than 30 days not just ones not created by an automated process. For example what happens if a XO backup job runs, creates a snapshot but the process is interrupted and the job fails. Will the next time the job runs clean up the previous failed jobs snapshot or is there a chance a snapshot could be left behind?
Garbage collection should be handling this...
-
In theory there's no such thing as XO checks. Now for the feature request, I prefer the idea of showing manual leftovers and leave the admin to decide what to do with it
-
you say here that this feature is implemented, but i don't see new menu. ec782
-
I think the dev working on it had personal issues few days before the release, so at worst it will be there in a patch release or in 5.106. There's so much things in the pipe, it's possible sometimes they aren't shipped on D-day. But it will be there finally
-
@olivierlambert haha, i'm watching you)
-
Merged. Works as intented, thank you.
-
T Tristis Oris marked this topic as a question on
-
T Tristis Oris has marked this topic as solved on
-
i found something to remove. Need to change text here, it too scary.
-
@Tristis-Oris I had the SAME thing today. The message scared me for 1min before I hit go.......
-
Hi,
I'm not sure to understand the issue. Removing those old snapshots makes you nervous because on the message telling you if you remove it the data associated with it will be remove? Or maybe it's just a phrasing thing? Like all "VM SNAPSHOTS" will be removed instead of VM only?
-
@olivierlambert "delete vm" "ALL vm disks will be removed" that wrong at least.
Yes, need to change it to snapshots. -
Why it's wrong? All the VM disks for this VM will be removed.
Remember: there's no "snapshot" object, it's only a VM with "is a snapshot: true".
-
@olivierlambert But on my side VM it's VM. Snapshot it's something else)
And not "all", "selected" sounds better. -
@olivierlambert !Delete VMs ->Delete VM Snapshots
delete 7 vms -> delete 7 VM snapshots
I you don't know as it is it scares you. Did me!
