XCP-ng
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Groups
    • Register
    • Login

    Manual snapshots retention

    Scheduled Pinned Locked Moved Solved Management
    46 Posts 6 Posters 18.0k Views 5 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • Tristis OrisT
      Tristis Oris Top contributor
      last edited by

      Would be nice to get global setting, how long to keep manual snapshots. Or maybe job rule to create a schedule task.

      1 Reply Last reply
      Reply Quote 0
      • olivierlambertO
        olivierlambert Vates 🪐 Co-Founder CEO
        last edited by

        So you mean, for the entire infrastructure, having a "garbage collector" that will automatically remove snapshots older than XXX ?

        Tristis OrisT 1 Reply Last reply
        Reply Quote 0
        • Tristis OrisT
          Tristis Oris Top contributor @olivierlambert
          last edited by

          @olivierlambert exactly.

          1 Reply Last reply
          Reply Quote 0
          • D
            DustinB
            last edited by

            Wouldn't this be incredibly dangerous?

            While I wouldn't be opposed to seeing a list of all VM's with manually created snapshots, I wouldn't want the system automatically deleting a snapshot that I made, because I might have need that snapshot for forensic and investigation purposes or some other legal requirement.

            Not that I have that requirement today, but it's plausible that as an organization it could happen.

            Tristis OrisT 1 Reply Last reply
            Reply Quote 0
            • Tristis OrisT
              Tristis Oris Top contributor @DustinB
              last edited by

              @DustinB well yes, it required some protection flag.

              F 1 Reply Last reply
              Reply Quote 0
              • F
                flakpyro @Tristis Oris
                last edited by

                I have often thought this might be something worth having in the health check area. Coming from VMware we used to frequently run a tool called "RVTools" that could show you old snapshots that may have been forgotten about or snapshots that were created by a failed backup job that were not removed properly. This would be useful to have to find snapshots like that and remove them before they become a problem.

                1 Reply Last reply
                Reply Quote 0
                • olivierlambertO
                  olivierlambert Vates 🪐 Co-Founder CEO
                  last edited by

                  Well, I'm not against that idea @flakpyro but we'd probably need some specification on what would be expected 🙂

                  F 1 Reply Last reply
                  Reply Quote 0
                  • F
                    flakpyro @olivierlambert
                    last edited by

                    @olivierlambert

                    Im not sure what the best criteria would be for listing the snapshot on the health check page. Perhaps if the snapshot is over 30 days old? There is already "Too many snapshots" (Not sure what counts as too many?) and "Orphaned VMs snapshot" perhaps just simply another section called "Old Snapshots"?

                    1 Reply Last reply
                    Reply Quote 0
                    • olivierlambertO
                      olivierlambert Vates 🪐 Co-Founder CEO
                      last edited by

                      Sure but it's all about discussing what would be the "best criteria" 😄

                      1 Reply Last reply
                      Reply Quote 1
                      • Tristis OrisT
                        Tristis Oris Top contributor
                        last edited by

                        Any snapshots from backup tasks should be protected from retention. Snapshots from removed backup tasks already visible at backup page.
                        When and after creating manual snapshot, should be an option to protect it from retention. And for batch snapshots maybe also? Kind of checkbox inside dropdown.

                        We use SH only for experiments\upgrades, so never care about. 30 days that already too late to use any restore (we still have backup). So usually i search them after few days via snapshots:length:>=2.

                        M 1 Reply Last reply
                        Reply Quote 0
                        • M
                          manilx @Tristis Oris
                          last edited by

                          @Tristis-Oris To be honest, this just opens more "configurations/complications" for a fringe case.....
                          Manual backups should never be deleted, unless I specifically do that (in an enterprise environment you don't necessarily know why they were made but there certainly was a reason fir them).

                          An information in the dashboard for backups "older" than x days could be interesting, yes.

                          D 1 Reply Last reply
                          Reply Quote 0
                          • D
                            DustinB @manilx
                            last edited by

                            @manilx said in Manual snapshots retention:

                            @Tristis-Oris To be honest, this just opens more "configurations/complications" for a fringe case.....
                            Manual backups should never be deleted, unless I specifically do that (in an enterprise environment you don't necessarily know why they were made but there certainly was a reason fir them).

                            An information in the dashboard for backups "older" than x days could be interesting, yes.

                            Right, I think having just a list of Snapshots older then X (that aren't created from a scheduled job) would be beneficial to validate that things aren't getting too long in the tooth.

                            1 Reply Last reply
                            Reply Quote 0
                            • olivierlambertO
                              olivierlambert Vates 🪐 Co-Founder CEO
                              last edited by

                              Could we have a consensus on how long? That would help to build the feature 😄

                              Tristis OrisT M 2 Replies Last reply
                              Reply Quote 0
                              • Tristis OrisT
                                Tristis Oris Top contributor @olivierlambert
                                last edited by Tristis Oris

                                @olivierlambert
                                for a custom amount of time?)

                                1 Reply Last reply
                                Reply Quote 0
                                • olivierlambertO
                                  olivierlambert Vates 🪐 Co-Founder CEO
                                  last edited by

                                  If we just want to display it in "Health view" that would be better to have at least a default value we all agree on 🙂

                                  Tristis OrisT 1 Reply Last reply
                                  Reply Quote 0
                                  • M
                                    manilx @olivierlambert
                                    last edited by

                                    @olivierlambert 30 days seems OK to me.

                                    1 Reply Last reply
                                    Reply Quote 0
                                    • Tristis OrisT
                                      Tristis Oris Top contributor @olivierlambert
                                      last edited by

                                      @olivierlambert well, 30 days is a super maximum for any real needs to restore anything.

                                      1 Reply Last reply
                                      Reply Quote 0
                                      • olivierlambertO
                                        olivierlambert Vates 🪐 Co-Founder CEO
                                        last edited by

                                        Done: https://github.com/vatesfr/xen-orchestra/issues/8258

                                        D 1 Reply Last reply
                                        Reply Quote 3
                                        • D
                                          DustinB @olivierlambert
                                          last edited by

                                          @olivierlambert I added a response in the hopes that it clarifies the end-goal.

                                          F 1 Reply Last reply
                                          Reply Quote 0
                                          • F
                                            flakpyro @DustinB
                                            last edited by

                                            @olivierlambert I wonder if it would be beneficial to show all snapshots older than 30 days not just ones not created by an automated process. For example what happens if a XO backup job runs, creates a snapshot but the process is interrupted and the job fails. Will the next time the job runs clean up the previous failed jobs snapshot or is there a chance a snapshot could be left behind?

                                            Tristis OrisT D 2 Replies Last reply
                                            Reply Quote 0

                                            Hello! It looks like you're interested in this conversation, but you don't have an account yet.

                                            Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.

                                            With your input, this post could be even better 💗

                                            Register Login
                                            • First post
                                              Last post