Setting "Protect from accidental deletion" breaks with backups and healtchecks

Pilow

@florent I did healthchecks one month or two ago.. I do not remember precisely

but I didn't have this bug.

so either specific to OP installation, or there is a regression somewhere

probain

I didn't have this before yesterday, which is when I updated. And I update from source regularly. So the regression has happened since the last few (<1w) days.

I'll step backwards and see which commit introduced the bug.

florent

@probain we fixed VM that was incorrectly updating their blocked operations, so maybe it's a case that "it's so broken that it works", and fixing one issue means doing more work to fix the full list

probain

@greg_e & @florent
I have gone back through the commits, and I believe it is 0a042d2f54a74ecc11a377809272337cb5c880d9 that introduces the bugg.
https://github.com/vatesfr/xen-orchestra/commit/0a042d2f54a74ecc11a377809272337cb5c880d9

My last known good and working commit is the one just prior to it, a831ac7b213eb6fc7f05fbd466407d5cf379cfe9.

Tried with the latest commit (as the time of writing). 91c5d98489b5981917ca0aabc28ac37acd448396. But this didn't fix it, unfortunately.

Filed a issue/bugg-report on github for this

https://github.com/vatesfr/xen-orchestra/issues/9472

@pilow
A lot of updates can, and do, happen in a month or two

cloudrootab created this issue in vatesfr/xen-orchestra

open Backup job failed: forbidden operation: destroy is blocked: protected from accidental deletion #9472

0

fbeauchamp committed to vatesfr/xen-orchestra

fix(xapi): correctly block operations

blocked operation on vm creation does not seem to work

also importIncrementalVm was not unlocking it at the end

Greg_E

@probain

I'm still on an older commit, being lazy and haven't had the time to update. Next week is Microsoft updates day, I may deal with XO the same day.

I run health checks on mine every night when they backup, so for me this could get big very fast. I think I'm going to continue to wait until there is more news on this issue, or I'll have to uncheck the accidental deletion box (not my desired choice). I'll let you know next week what I decided.

probain

@Greg_E
or just uncheck the "protection"-flag. But that get tedious very quickly. And I only had to do it on 6 VMs.

florent

@Greg_E the fix is in review, it should be on master today

florent

the fix is merged into master

Greg_E

@florent

Thanks. I'm still going to wait until next week, my schedule just doesn't give me the time right now. But nice to know that when I do update, it will be fixed and my laziness prevented a problem for me

I think I'll get my pool updated today, only been waiting a week at this point.

probain

@florent said in Setting "Protect from accidental deletion" breaks with backups and healtchecks:

the fix is merged into master

I can confirm that the problem has now been solved. And will mark the raised github-issue as closed as well.

probain

Also..
Thank you for taking a look at it and solving it so quickly, @florent

It is a quite nice interaction when reporting bugs that they are looked at and triaged. Not saying everything needs to be a priority 1. But I do appreciate being close to the process. And if I can help make things better by reporting bugs, in a hopefully constructive way. Then I'll continue to contribute my way.