S3 Backup Restore File Issue

[stevewest15]

Xen Orchestra, commit 2e8e2
xo-server 5.86.3
xo-web 5.91.2

Hello,

Does backups to S3 support restoring from files? Just tried it and I'm getting the following error:

Error logs show the following:

backupNg.listPartitions
{
  "remote": "b241d7ad-9e91-4763-96a2-0fe0e54e94c7",
  "disk": "/xo-vm-backups/012b07a1-24cf-6d59-5faf-804e0e187b7a/vdis/5f1c8cfb-e4f5-4571-8a48-50b03c5e0d93/94396c87-11b4-4f0e-a996-985cb74d07bf/20220127T042837Z.alias.vhd"
}
{
  "message": "handler._getFilePath is not a function",
  "name": "TypeError",
  "stack": "TypeError: handler._getFilePath is not a function
    at RemoteAdapter.getDisk (/opt/xen-orchestra/@xen-orchestra/backups/RemoteAdapter.js:306:30)
    at getDisk.next (<anonymous>)
    at wrapCall (/opt/xen-orchestra/node_modules/promise-toolbox/wrapCall.js:7:23)
    at loop (/opt/xen-orchestra/node_modules/promise-toolbox/Disposable.js:96:25)
    at RemoteAdapter.getDisk (/opt/xen-orchestra/node_modules/promise-toolbox/Disposable.js:98:10)
    at RemoteAdapter.<anonymous> (/opt/xen-orchestra/@vates/disposable/deduped.js:18:32)
    at RemoteAdapter.getDisk (/opt/xen-orchestra/@xen-orchestra/backups/RemoteAdapter.js:67:43)
    at RemoteAdapter.listPartitions (/opt/xen-orchestra/@xen-orchestra/backups/RemoteAdapter.js:402:32)
    at Function.<anonymous> (file:///opt/xen-orchestra/packages/xo-server/src/xo-mixins/file-restore-ng.mjs:83:85)
    at wrapApply (/opt/xen-orchestra/node_modules/promise-toolbox/wrapApply.js:7:23)
    at /opt/xen-orchestra/node_modules/promise-toolbox/Disposable.js:143:91
    at AsyncResource.runInAsyncScope (node:async_hooks:199:9)
    at cb (/opt/xen-orchestra/node_modules/bluebird/js/release/util.js:355:42)
    at tryCatcher (/opt/xen-orchestra/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/opt/xen-orchestra/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/opt/xen-orchestra/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/opt/xen-orchestra/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/opt/xen-orchestra/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/opt/xen-orchestra/node_modules/bluebird/js/release/promise.js:673:18)
    at Promise._resolveCallback (/opt/xen-orchestra/node_modules/bluebird/js/release/promise.js:466:57)
    at Promise._settlePromiseFromHandler (/opt/xen-orchestra/node_modules/bluebird/js/release/promise.js:559:17)
    at Promise._settlePromise (/opt/xen-orchestra/node_modules/bluebird/js/release/promise.js:604:18)"
}

Thank You,

SW

[julien-f]

@stevewest15 Hi, thanks for your report. File restore is indeed not supported for S3 backups (and it won't be due to implementation limits), we will make this clearer in the UI though

[olivierlambert]

I don't think file restore is supported on S3 (yet or will be?). Let me ping @julien-f

[julien-f]

@stevewest15 Hi, thanks for your report. File restore is indeed not supported for S3 backups (and it won't be due to implementation limits), we will make this clearer in the UI though

[stevewest15]

Thank you greatly appreciate your assistance as always!