XO - Restore Health Check

nikade

Hi everyone,

Has anyone else tried the Restore Health Check-feature in XO to test their backups?
I've used it now in my lab a couple of times and it works great, but one thing that bugs me out is that the name of the tested VM is no longer dispalyed after the TEST is finished because it was removed:

Instead of listing the name of the VM it just says "VM not found!"

We're using XO from sources:

Xen Orchestra, commit 8b7e1
Master, commit 587da

olivierlambert

Ping @florent maybe

planedrop

I can confirm this is the case for me too, not a huge deal, but would be kinda nice if it could keep track of the name.

nikade

@planedrop said in XO - Restore Health Check:

I can confirm this is the case for me too, not a huge deal, but would be kinda nice if it could keep track of the name.

Thanks for verifying, it is probably an easy fix for the vates ppl

olivierlambert

Since Flo is AFK, maybe @MathieuRA can take a quick look (if it's only a display thing that would make sense)

MathieuRA

Hi, @nikade
As you said, the VM is deleted at the end of the health-check, and it will not be trivial to keep the VM name.

BTW, maybe we can add a column.
So the current VM column will point to the VM used for the health-check (no change), and the new column will point to the backuped VM. What do you think?

nikade

@MathieuRA said in XO - Restore Health Check:

Hi, @nikade
As you said, the VM is deleted at the end of the health-check, and it will not be trivial to keep the VM name.

BTW, maybe we can add a column.
So the current VM column will point to the VM used for the health-check (no change), and the new column will point to the backuped VM. What do you think?

Cant you just read $name and print $name in the column instead of a hyperlink to the VM (when it is deleted)?
This is the flow that I imagine:

Health check starts -> $name of VM is recorded -> $name is listed as a hyperlink in the VM column -> VM is deleted -> $name is listed as text in the VM column.

MathieuRA

@nikade said in XO - Restore Health Check:

of VM is recorded -> $name is listed as a hyperlink in the VM column -> VM is deleted -> $name is listed as text in the VM column.

No we can't, we do not have direct access to the VM name.
We must first find the VM using an ID and then return the name_label property of the VM object.

nikade

@MathieuRA said in XO - Restore Health Check:

@nikade said in XO - Restore Health Check:

of VM is recorded -> $name is listed as a hyperlink in the VM column -> VM is deleted -> $name is listed as text in the VM column.

No we can't, we do not have direct access to the VM name.
We must first find the VM using an ID and then return the name_label property of the VM object.

OK, so it is possible!

MathieuRA

@nikade said in XO - Restore Health Check:

OK, so it is possible!

Reply

If the VM is deleted, we can no longer find it, so we cannot retrieve the name label property of an object that does not exist.

MathieuRA

At least for XO5, there is no trivial way to do that.

So will probably need to wait for XO6.