XO Hosed on new update

Andrew

I updated to today's XO source commit 36b94f745d7a678b60e393bd8f8377f17dcd681b and everything is hosed, FUBAR, borked, très cassé, you know.... non-functional.

I'll my server settings were broken (blank fields). I removed them and could not add others. I get an error (Invalid argument type). Backup jobs were gone and I could not add a new one (page hangs).

Reverting did not help, I had to restore to an older snapshot, so maybe an updated dependency that's not part of the compiled code.

Using yesterday's commit d87db05b2bee125305bf84d537246ee16342a198, XO was working.

julien-f

Should be fixed now, please let me know if you have other issues.

https://github.com/vatesfr/xen-orchestra/commit/d27b6bd49d1885b385f3488c78ce4ddc392a69e2

0

julien-f committed to vatesfr/xen-orchestra

fix(xo-server/collection/redis#{add,update}): cast to string before inserting in db

Fixes https://xcp-ng.org/forum/post/51933
Fixes #6359

Introduced by 36b94f745

olivierlambert

Ping @julien-f

julien-f

@Andrew Sorry for bug, it broke added/updated objects in the database, you will need to re-import an existing XO config or fix the problems manually.

https://github.com/vatesfr/xen-orchestra/commit/7418d9f6708c171c37ae3867ac4ccdeaf4b2b345

0

julien-f committed to vatesfr/xen-orchestra

fix(xo-server/collection/redis#{add,update}): save all fields

Fixes https://xcp-ng.org/forum/post/51916

Introduced by 36b94f745

`Redis#hSet` accepts an object instead of a sequence of key/value.

The previous commit corrupted the database by deleting all but one fields per added/updated objects.

Andrew

@julien-f Better now...

I still get an error creating a remote for a backup job:

remote.create
{
  "name": "minio-S3",
  "url": "s3://key:pass@minio-test/downtown/backup?useVhdDirectory=true"
}
{
  "message": "Invalid argument type",
  "name": "TypeError",
  "stack": "TypeError: Invalid argument type
    at encodeCommand (/opt/xo/xo-builds/xen-orchestra-202208061156/node_modules/@redis/client/dist/lib/client/RESP2/encoder.js:17:19)
    at RedisCommandsQueue.getCommandToSend (/opt/xo/xo-builds/xen-orchestra-202208061156/node_modules/@redis/client/dist/lib/client/commands-queue.js:187:45)
    at Commander._RedisClient_tick (/opt/xo/xo-builds/xen-orchestra-202208061156/node_modules/@redis/client/dist/lib/client/index.js:434:76)
    at Commander._RedisClient_sendCommand (/opt/xo/xo-builds/xen-orchestra-202208061156/node_modules/@redis/client/dist/lib/client/index.js:418:82)
    at Commander.commandsExecutor (/opt/xo/xo-builds/xen-orchestra-202208061156/node_modules/@redis/client/dist/lib/client/index.js:170:154)
    at Commander.hSet (/opt/xo/xo-builds/xen-orchestra-202208061156/node_modules/@redis/client/dist/lib/commander.js:8:29)
    at file:///opt/xo/xo-builds/xen-orchestra-202208061156/packages/xo-server/src/collection/redis.mjs:161:17"
}

Andrew

@julien-f I deleted everything I could find and reinstalled XO from source and can't add anything... Same Invalid argument type message on adding a server.

ronivay

I can reproduce same error with a fresh from sources installation when trying to add server.

julien-f

Should be fixed now, please let me know if you have other issues.

https://github.com/vatesfr/xen-orchestra/commit/d27b6bd49d1885b385f3488c78ce4ddc392a69e2

0

julien-f committed to vatesfr/xen-orchestra

fix(xo-server/collection/redis#{add,update}): cast to string before inserting in db

Fixes https://xcp-ng.org/forum/post/51933
Fixes #6359

Introduced by 36b94f745

Andrew

@julien-f Much better! I can add servers/remotes/jobs again. Thanks!