xo-cli --register produces "invalid parameters" errors in xo logs

mietek

I have written a script downloading info about the whole cluster using xo-cli.

The simple command:

/usr/bin/xo-cli --register --allowUnauthorized https://<web\_address> <user> <pass>

even though login is successful:

Successfully logged with <username>

is producing these errors in xo logs:

token.create
{
  "description": "xo-cli --register"
}
{
  "code": 10,
  "data": {
    "errors": [
      {
        "code": null,
        "reason": "strict",
        "message": "should not contains property [\"description\"]",
        "property": "@"
      }
    ]
  },
  "message": "invalid parameters",
  "name": "XoError",
  "stack": "XoError: invalid parameters
    at Module.invalidParameters (/opt/xen-orchestra/packages/xo-common/src/api-errors.js:21:32)
    at Object.call (file:///opt/xen-orchestra/packages/xo-server/src/xo-mixins/api.mjs:73:18)
    at Api.callApiMethod (file:///opt/xen-orchestra/packages/xo-server/src/xo-mixins/api.mjs:303:19)"
}

Any tips on what is the issue and how to eliminate it spamming the logs?

(script has to run periodically)

julien-f

@mietek Hello, this is due to incompatibility between xo-cli and xo-server due a change introduced 6 months ago, you can resolve it by updating xo-server.

Another solution is to update xo-cli as the recent versions contains a work-around for old versions of xo-server.

Darkbeldin

@mietek pinging @julien-f for him to take a look

julien-f

@mietek Hello, this is due to incompatibility between xo-cli and xo-server due a change introduced 6 months ago, you can resolve it by updating xo-server.

Another solution is to update xo-cli as the recent versions contains a work-around for old versions of xo-server.

mietek

@julien-f Hey, thanks for the info. Let me update the client and get back to you.

mietek

@julien-f
upgrade or reinstall of xo-cli crashes now with an error:

internal/process/esm_loader.js:74
    internalBinding('errors').triggerUncaughtException(
                              ^

Error [ERR_UNKNOWN_BUILTIN_MODULE]: No such built-in module: node:assert/strict
    at new NodeError (internal/errors.js:322:7)
    at Function.Module._load (internal/modules/cjs/loader.js:781:13)
    at Module.require (internal/modules/cjs/loader.js:1003:19)
    at require (internal/modules/cjs/helpers.js:107:18)
    at Object.<anonymous> (/usr/lib/node_modules/xo-cli/node_modules/http-request-plus/index.js:5:16)
    at Module._compile (internal/modules/cjs/loader.js:1114:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1143:10)
    at Module.load (internal/modules/cjs/loader.js:979:32)
    at Function.Module._load (internal/modules/cjs/loader.js:819:12)
    at ModuleWrap.<anonymous> (internal/modules/esm/translators.js:203:29) {
  code: 'ERR_UNKNOWN_BUILTIN_MODULE'

I am not really a Java guy. What am I missing here?

julien-f

@mietek Does xo-cli crash? Or npm during the install?

mietek

@julien-f xo-cli installation runs fine. Trying to run it fails.
I have rolled it back to 0.14.0 and it works fine.

julien-f

@mietek Ok, which version of Node are you using?

mietek

@julien-f v14.21.3

julien-f

@mietek Please use latest Node LTS as explained in the documentation.

mietek

@julien-f I have installed node LTS ver and the new xo-cli works fine:

nodejs:
->     v16.20.0   (Latest LTS: Gallium)
xo-cli:
└── xo-cli@0.17.1

Thanks for help.

olivierlambert

That's why it's important to read the doc, because it means less interruption and more time for @julien-f to actually work on improving XO

mietek

Hey @julien-f, I have to get back to the issue as I had to move witn node and xo-cli to other machine and even though I have node: v16.20.0 and xo-cli: v0.17.1
I see those errors again.
Is there any way to have it fixed without upgrading xo-server? [ver: 5.87.0]

julien-f

@mietek The No such built-in module: node:assert/strict cannot occur with Node 16.20.0.

What exact issues do you have?

olivierlambert

If you are using xo-server 5.87.0 you are indeed very very outdated. Remember to keep everything up to date on master branch as possible.

mietek

@julien-f Hey, I am back to the original issue now:
"message": "should not contains property ["description"]

If there is anything I can do to not have it in logs then great, but if not
@olivierlambert might be right that it's time to finally upgrade the server version.

julien-f

@mietek I cannot reproduce the problem with xo-cli@0.17.1, either with xo-server@5.87.0 nor with xo-server@5.111.1.

Anyway, old versions are not supported, please upgrade.

If you have a paying subscription and a special need, please open a support ticket.

mietek

@julien-f OK, server upgrade it is.
Thanks for a prompt reply. Appreciate it.