Error on vm.restart - invalid parameters

[Tristis Oris]

commit 8c24d
3 pools, 3 vms, 3 separate tasks to reboot each host.
On 1 pool task is never executed, other works.
I dunno what the difference between them. Similar hardware and network.

vm.restart
{
  "bypassBackupCheck": true,
  "bypassBlockedSuspend": true,
  "bypassCurrentVmCheck": true,
  "id": "543380ec-cdfe-af2e-5edd-f0154773b030",
  "bypassBlockedOperation": true
}
{
  "code": 10,
  "data": {
    "errors": [
      {
        "instancePath": "",
        "schemaPath": "#/additionalProperties",
        "keyword": "additionalProperties",
        "params": {
          "additionalProperty": "bypassBackupCheck"
        },
        "message": "must NOT have additional properties"
      },
      {
        "instancePath": "",
        "schemaPath": "#/additionalProperties",
        "keyword": "additionalProperties",
        "params": {
          "additionalProperty": "bypassBlockedSuspend"
        },
        "message": "must NOT have additional properties"
      },
      {
        "instancePath": "",
        "schemaPath": "#/additionalProperties",
        "keyword": "additionalProperties",
        "params": {
          "additionalProperty": "bypassCurrentVmCheck"
        },
        "message": "must NOT have additional properties"
      }
    ]
  },
  "message": "invalid parameters",
  "name": "XoError",
  "stack": "XoError: invalid parameters
    at Module.invalidParameters (/opt/xo/xo-builds/xen-orchestra-202312291002/packages/xo-common/api-errors.js:26:11)
    at Xo.call (file:///opt/xo/xo-builds/xen-orchestra-202312291002/packages/xo-server/src/xo-mixins/api.mjs:92:22)
    at Api.#callApiMethod (file:///opt/xo/xo-builds/xen-orchestra-202312291002/packages/xo-server/src/xo-mixins/api.mjs:441:19)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at processImmediate (node:internal/timers:447:9)
    at process.callbackTrampoline (node:internal/async_hooks:128:17)"
}vm.restart
{
  "bypassBackupCheck": true,
  "bypassBlockedSuspend": true,
  "bypassCurrentVmCheck": true,
  "id": "543380ec-cdfe-af2e-5edd-f0154773b030",
  "bypassBlockedOperation": true
}
{
  "code": 10,
  "data": {
    "errors": [
      {
        "instancePath": "",
        "schemaPath": "#/additionalProperties",
        "keyword": "additionalProperties",
        "params": {
          "additionalProperty": "bypassBackupCheck"
        },
        "message": "must NOT have additional properties"
      },
      {
        "instancePath": "",
        "schemaPath": "#/additionalProperties",
        "keyword": "additionalProperties",
        "params": {
          "additionalProperty": "bypassBlockedSuspend"
        },
        "message": "must NOT have additional properties"
      },
      {
        "instancePath": "",
        "schemaPath": "#/additionalProperties",
        "keyword": "additionalProperties",
        "params": {
          "additionalProperty": "bypassCurrentVmCheck"
        },
        "message": "must NOT have additional properties"
      }
    ]
  },
  "message": "invalid parameters",
  "name": "XoError",
  "stack": "XoError: invalid parameters
    at Module.invalidParameters (/opt/xo/xo-builds/xen-orchestra-202312291002/packages/xo-common/api-errors.js:26:11)
    at Xo.call (file:///opt/xo/xo-builds/xen-orchestra-202312291002/packages/xo-server/src/xo-mixins/api.mjs:92:22)
    at Api.#callApiMethod (file:///opt/xo/xo-builds/xen-orchestra-202312291002/packages/xo-server/src/xo-mixins/api.mjs:441:19)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at processImmediate (node:internal/timers:447:9)
    at process.callbackTrampoline (node:internal/async_hooks:128:17)"
}

[olivierlambert]

Ping @julien-f

[julien-f]

I confirm this bug, it happens when editing a job and changing its method, the previous params are incorrectly kept.

I'm checking whether it's easy to fix.

[julien-f]

@Tristis-Oris Fixed: https://github.com/vatesfr/xen-orchestra/commit/be452a5d63b8f4d2276065d06d455e18ec693979

Let me know if you have any issues

0 julien-f committed to vatesfr/xen-orchestra

fix(xo-web/jobs/new): reset params on method change

Fixes https://xcp-ng.org/forum/post/69299

[Tristis Oris]

@julien-f
updated.

• job not working.
• edit and save job again - not working too.
• edit another job (without problem) - it works.
  So i just recreate this job, problem should not happens again.

Thank you.

[julien-f]

@Tristis-Oris To fix problematic jobs:

• edit
• change method
• change method back
• re-enter parameters
• save

[Tristis Oris]

@julien-f i only try to edit bypass method, that doesn't help. But already removed old job.