Can't delete disconnected server in settings

[Andrew]

@olivierlambert In XOA 5.109.0 and XO (master 31a3f), I'm trying to delete a disconnected server, but it gives me an error, this should be allowed.

server.remove
{
  "id": "7c2131df-2798-4837-9770-6e01facb7629"
}
{
  "code": 25,
  "data": {
    "actual": "disconnected",
    "expected": [
      "connected",
      "connecting"
    ],
    "object": "7c2131df-2798-4837-9770-6e01facb7629",
    "property": "status"
  },
  "message": "incorrect state",
  "name": "XoError",
  "stack": "XoError: incorrect state
    at incorrectState (/usr/local/lib/node_modules/xo-server/node_modules/xo-common/src/api-errors.js:21:32)
    at XenServers.disconnectXenServer (file:///usr/local/lib/node_modules/xo-server/src/xo-mixins/xen-servers.mjs:541:13)
    at XenServers.unregisterXenServer (file:///usr/local/lib/node_modules/xo-server/src/xo-mixins/xen-servers.mjs:133:5)
    at Xo.remove (file:///usr/local/lib/node_modules/xo-server/src/api/server.mjs:48:3)
    at Task.runInside (/usr/local/lib/node_modules/xo-server/node_modules/@vates/task/index.js:175:22)
    at Task.run (/usr/local/lib/node_modules/xo-server/node_modules/@vates/task/index.js:159:20)
    at Api.#callApiMethod (file:///usr/local/lib/node_modules/xo-server/src/xo-mixins/api.mjs:469:18)"
}

[Danp]

Hi @Andrew,

Thanks for the report. I'm seeing the same on my end, so I'll pass this along to the developers.

Dan

[MathieuRA]

Hi @Andrew.
This PR should fix your issue https://github.com/vatesfr/xen-orchestra/pull/8854

MathieuRA opened this pull request in vatesfr/xen-orchestra

closed fix(xo-server): fix incorrect state when remove server #8854