Manual snapshots retention
-
Well, I'm not against that idea @flakpyro but we'd probably need some specification on what would be expected
-
Im not sure what the best criteria would be for listing the snapshot on the health check page. Perhaps if the snapshot is over 30 days old? There is already "Too many snapshots" (Not sure what counts as too many?) and "Orphaned VMs snapshot" perhaps just simply another section called "Old Snapshots"?
-
Sure but it's all about discussing what would be the "best criteria"
-
Any snapshots from backup tasks should be protected from retention. Snapshots from removed backup tasks already visible at backup page.
When and after creating manual snapshot, should be an option to protect it from retention. And for batch snapshots maybe also? Kind of checkbox inside dropdown.We use SH only for experiments\upgrades, so never care about. 30 days that already too late to use any restore (we still have backup). So usually i search them after few days via
snapshots:length:>=2. -
@Tristis-Oris To be honest, this just opens more "configurations/complications" for a fringe case.....
Manual backups should never be deleted, unless I specifically do that (in an enterprise environment you don't necessarily know why they were made but there certainly was a reason fir them).An information in the dashboard for backups "older" than x days could be interesting, yes.
-
@manilx said in Manual snapshots retention:
@Tristis-Oris To be honest, this just opens more "configurations/complications" for a fringe case.....
Manual backups should never be deleted, unless I specifically do that (in an enterprise environment you don't necessarily know why they were made but there certainly was a reason fir them).An information in the dashboard for backups "older" than x days could be interesting, yes.
Right, I think having just a list of Snapshots older then X (that aren't created from a scheduled job) would be beneficial to validate that things aren't getting too long in the tooth.
-
Could we have a consensus on how long? That would help to build the feature
-
@olivierlambert
for a custom amount of time?) -
If we just want to display it in "Health view" that would be better to have at least a default value we all agree on
-
@olivierlambert 30 days seems OK to me.
-
@olivierlambert well, 30 days is a super maximum for any real needs to restore anything.
-
-
@olivierlambert I added a response in the hopes that it clarifies the end-goal.
-
@olivierlambert I wonder if it would be beneficial to show all snapshots older than 30 days not just ones not created by an automated process. For example what happens if a XO backup job runs, creates a snapshot but the process is interrupted and the job fails. Will the next time the job runs clean up the previous failed jobs snapshot or is there a chance a snapshot could be left behind?
-
@flakpyro true, sometimes that happens and they will never be deleted.
I'm don't remember, but maybe such snaspshots not visible as orphaned. -
@flakpyro said in Manual snapshots retention:
@olivierlambert I wonder if it would be beneficial to show all snapshots older than 30 days not just ones not created by an automated process. For example what happens if a XO backup job runs, creates a snapshot but the process is interrupted and the job fails. Will the next time the job runs clean up the previous failed jobs snapshot or is there a chance a snapshot could be left behind?
Garbage collection should be handling this...
-
In theory there's no such thing as XO checks. Now for the feature request, I prefer the idea of showing manual leftovers and leave the admin to decide what to do with it
-
you say here that this feature is implemented, but i don't see new menu. ec782
-
I think the dev working on it had personal issues few days before the release, so at worst it will be there in a patch release or in 5.106. There's so much things in the pipe, it's possible sometimes they aren't shipped on D-day. But it will be there finally
-
@olivierlambert haha, i'm watching you)
