XCP-ng
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Groups
    • Register
    • Login

    Manual snapshots retention

    Scheduled Pinned Locked Moved Solved Management
    27 Posts 5 Posters 524 Views 3 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • olivierlambertO Online
      olivierlambert Vates 🪐 Co-Founder CEO
      last edited by

      Sure but it's all about discussing what would be the "best criteria" 😄

      1 Reply Last reply Reply Quote 1
      • Tristis OrisT Offline
        Tristis Oris Top contributor
        last edited by

        Any snapshots from backup tasks should be protected from retention. Snapshots from removed backup tasks already visible at backup page.
        When and after creating manual snapshot, should be an option to protect it from retention. And for batch snapshots maybe also? Kind of checkbox inside dropdown.

        We use SH only for experiments\upgrades, so never care about. 30 days that already too late to use any restore (we still have backup). So usually i search them after few days via snapshots:length:>=2.

        M 1 Reply Last reply Reply Quote 0
        • M Offline
          manilx @Tristis Oris
          last edited by

          Tristis Oris To be honest, this just opens more "configurations/complications" for a fringe case.....
          Manual backups should never be deleted, unless I specifically do that (in an enterprise environment you don't necessarily know why they were made but there certainly was a reason fir them).

          An information in the dashboard for backups "older" than x days could be interesting, yes.

          D 1 Reply Last reply Reply Quote 0
          • D Offline
            DustinB @manilx
            last edited by

            manilx said in Manual snapshots retention:

            Tristis Oris To be honest, this just opens more "configurations/complications" for a fringe case.....
            Manual backups should never be deleted, unless I specifically do that (in an enterprise environment you don't necessarily know why they were made but there certainly was a reason fir them).

            An information in the dashboard for backups "older" than x days could be interesting, yes.

            Right, I think having just a list of Snapshots older then X (that aren't created from a scheduled job) would be beneficial to validate that things aren't getting too long in the tooth.

            1 Reply Last reply Reply Quote 0
            • olivierlambertO Online
              olivierlambert Vates 🪐 Co-Founder CEO
              last edited by

              Could we have a consensus on how long? That would help to build the feature 😄

              Tristis OrisT M 2 Replies Last reply Reply Quote 0
              • Tristis OrisT Offline
                Tristis Oris Top contributor @olivierlambert
                last edited by Tristis Oris

                olivierlambert
                for a custom amount of time?)

                1 Reply Last reply Reply Quote 0
                • olivierlambertO Online
                  olivierlambert Vates 🪐 Co-Founder CEO
                  last edited by

                  If we just want to display it in "Health view" that would be better to have at least a default value we all agree on 🙂

                  Tristis OrisT 1 Reply Last reply Reply Quote 0
                  • M Offline
                    manilx @olivierlambert
                    last edited by

                    olivierlambert 30 days seems OK to me.

                    1 Reply Last reply Reply Quote 0
                    • Tristis OrisT Offline
                      Tristis Oris Top contributor @olivierlambert
                      last edited by

                      olivierlambert well, 30 days is a super maximum for any real needs to restore anything.

                      1 Reply Last reply Reply Quote 0
                      • olivierlambertO Online
                        olivierlambert Vates 🪐 Co-Founder CEO
                        last edited by

                        Done: https://github.com/vatesfr/xen-orchestra/issues/8258

                        olivierlambert created this issue in vatesfr/xen-orchestra

                        closed Healthview: display snapshots older than 30 days #8258

                        D 1 Reply Last reply Reply Quote 2
                        • D Offline
                          DustinB @olivierlambert
                          last edited by

                          olivierlambert I added a response in the hopes that it clarifies the end-goal.

                          F 1 Reply Last reply Reply Quote 0
                          • F Offline
                            flakpyro @DustinB
                            last edited by

                            olivierlambert I wonder if it would be beneficial to show all snapshots older than 30 days not just ones not created by an automated process. For example what happens if a XO backup job runs, creates a snapshot but the process is interrupted and the job fails. Will the next time the job runs clean up the previous failed jobs snapshot or is there a chance a snapshot could be left behind?

                            Tristis OrisT D 2 Replies Last reply Reply Quote 0
                            • Tristis OrisT Offline
                              Tristis Oris Top contributor @flakpyro
                              last edited by

                              flakpyro true, sometimes that happens and they will never be deleted.
                              I'm don't remember, but maybe such snaspshots not visible as orphaned.

                              1 Reply Last reply Reply Quote 0
                              • D Offline
                                DustinB @flakpyro
                                last edited by

                                flakpyro said in Manual snapshots retention:

                                olivierlambert I wonder if it would be beneficial to show all snapshots older than 30 days not just ones not created by an automated process. For example what happens if a XO backup job runs, creates a snapshot but the process is interrupted and the job fails. Will the next time the job runs clean up the previous failed jobs snapshot or is there a chance a snapshot could be left behind?

                                Garbage collection should be handling this...

                                1 Reply Last reply Reply Quote 0
                                • olivierlambertO Online
                                  olivierlambert Vates 🪐 Co-Founder CEO
                                  last edited by

                                  In theory there's no such thing as XO checks. Now for the feature request, I prefer the idea of showing manual leftovers and leave the admin to decide what to do with it 🙂

                                  1 Reply Last reply Reply Quote 2
                                  • Tristis OrisT Offline
                                    Tristis Oris Top contributor
                                    last edited by

                                    you say here that this feature is implemented, but i don't see new menu. ec782

                                    1 Reply Last reply Reply Quote 0
                                    • olivierlambertO Online
                                      olivierlambert Vates 🪐 Co-Founder CEO
                                      last edited by

                                      I think the dev working on it had personal issues few days before the release, so at worst it will be there in a patch release or in 5.106. There's so much things in the pipe, it's possible sometimes they aren't shipped on D-day. But it will be there finally 🙂

                                      Tristis OrisT 1 Reply Last reply Reply Quote 1
                                      • Tristis OrisT Offline
                                        Tristis Oris Top contributor @olivierlambert
                                        last edited by

                                        olivierlambert haha, i'm watching you)

                                        1 Reply Last reply Reply Quote 0
                                        • Tristis OrisT Offline
                                          Tristis Oris Top contributor
                                          last edited by

                                          Merged. Works as intented, thank you.

                                          1 Reply Last reply Reply Quote 1
                                          • Tristis OrisT Tristis Oris marked this topic as a question
                                          • Tristis OrisT Tristis Oris has marked this topic as solved
                                          • First post
                                            Last post