backup mail report says INTERRUPTED but it's not ?

[olivierlambert]

@Pilow Thanks, it's promising but we'll wait for more runs on your side If it's that, at least it's not a biggie in the end!

[Bastien Nollet]

I agree, let's wait for more runs.

If it's indeed a race condition, we'll still have to figure out a better way to settle this than just adding delay

[Pilow]

@Bastien-Nollet new day without false INTERRUPTED

the scrutiny of backup email reports made me find a new bug in backups (not reports this time)
i'll create a new topic about the dreaded BACKUP FELL BACK TO A FULL --> can provoke it on purpose !

[Bastien Nollet]

Thanks @Pilow for the tests.

We'll have to investigate this to fix it more properly than adding a ugly delay.

[Pilow]

@Bastien-Nollet another good day

I think i'll swap to feedback if problem is back than problem is not here anymore

on your side to find something sexier than delay ^^' but it seems to be a race condition

[Bastien Nollet]

Hi @Pilow,

Thanks again for the feedback, I think now we have enough data to be sure it's indeed a race condition.

We noticed that the log you sent earlier in this topic is a backup job using a proxy. Could you tell if the backup jobs that ended up with a wrong status in the report were all using a proxy, or not all of them?

[Pilow]

@Bastien-Nollet 100% of our backup jobs are done by proxy
we offload that of main XOA that is purely for administration/management

[Bastien Nollet]

Hi @Pilow,

I've done some more testing and looked at the code, and I wasn't able to reproduce this behaviour once. It's also unclear to me why it can happen.

We may just add the delay as you did, but 10s is probably too long. Could you try to replace it by a 1s delay instead, and tell us if it's enough?

[Pilow]

@Bastien-Nollet okay i'll do that tonight and will report back

[Pilow]

26 backups in a row without interruption, spanning 2 days
And i'm on the 1 second fix

guess it is enough...

@Bastien-Nollet said in backup mail report says INTERRUPTED but it's not ?:

I've done some more testing and looked at the code, and I wasn't able to reproduce this behaviour once. It's also unclear to me why it can happen.

I didn't tell but my Remotes are S3 Remotes... could it be because of that ?

[Bastien Nollet]

Thanks again @Pilow

I don't think the remotes being S3 changes something here.

[Pilow]

@Bastien-Nollet oopsy.

sadly, INTERRUPTED is back....

this is what I see in the backup report (a backup job of 12VMs to same S3 remote, only 1 interrupted...)

backup JOB in XOA is all green :

[Bastien Nollet]

Ok so 1s is slightly not enough, thanks for the update.

[Pilow]

@Bastien-Nollet another interrupted today.
I'll add one second by one second till I see it disappear.

just modified to 2s delay.

[Pilow]

@Bastien-Nollet said in backup mail report says INTERRUPTED but it's not ?:

Ok so 1s is slightly not enough, thanks for the update.

Reply

still had issues with 2 sec delay.

it has now been 2 days with 3 sec delay, and no more. could be the sweet spot

[Bastien Nollet]

We're still carrying a bit of investigations to see if we can find the cause of the problem, but if we don't find it we'll add this delay.

Thanks @Pilow for the tests once again

[Bastien Nollet]

We just merged the delay: https://github.com/vatesfr/xen-orchestra/pull/9400

We increased it to 5s to have a security margin, as the optimal delay may not be the same on different configurations.

b-Nollet opened this pull request in vatesfr/xen-orchestra

closed fix(backup-reports): prevent succesful backups being sometimes repor… #9400

[Pilow]

@Bastien-Nollet many thanks