Xen Orchestra has stopped updating commits

olivierlambert

Hi,

Have you double checked your current NodeJS version?

Danp

@JamfoFL said in Xen Orchestra has stopped updating commits:

When I run the yarn build command, a bunch of stuff flies by on the screen, but it completes MUCH faster than it ever had in the past

Most likely this is due to the recent additional of Turborepo. You can read more about the change here.

Did you try pressing F5 on the About screen to see if the commit changes when you refresh the page?

JamfoFL

@Danp @olivierlambert

Wow! Thank you for the very rapid reply!

The current NodeJS version on the system is: v18.9.0

I just tried pressing the F5 key on the About screen, to no avail. I see it flicker, so I know it's responding to the key press, but still show the same commit, a1050.

I even tried rebooting the server and that didn't make a difference, either.

I noticed that there is a newer version of NodeJS available, v19.4.0, so I updated to that version and it made things worse. Now, when I go into Xen Orchestra, on the Home screen it says I am not connected to an XCP-ng hosts. However, when I got into servers, it shows I am connected! What's even weirder is if I wait long enough, all of my servers will show up on the home screen for about 30 seconds before they disappear again. This happens continuously.

And, even after all that, it still shows I am on the same commit.

Danp

@JamfoFL Node LTS is currently v18.13.0, so that is what you should be running.

You may want to try the following troubleshooting steps --

 rm -rf node_modules
 yarn
 yarn build

Are you running xo-server as a service. If so, have you restarted it following the rebuild?

Danp

I just checked and I'm seeing similar issues. After updating to the latest source, git shows me on commit d0b3d, but XO says I'm on e6b89.

Danp

Looking at the files in the .git subdirectory, ORIG_HEAD contains e6b893977205a90f5d7b96e8e0e0f65b030fa195 while the first line of FETCH_HEAD shows d0b3d7863931981ec90db08891b972c9e097030f branch 'master' of https://github.com/vatesfr/xen-orchestra .

JamfoFL

@Danp I tried the troubleshooting steps you recommended and restarted and still see the same issue... but it looks like you are seeing the same thing now. So I'm assuming there's nothing I can do as of now? Anything I should try, or is this something that will need to be fixed in another commit?

Also... if you have a spare moment, how do I update Node LTS to that version? Every time I try to update, it wants to go to the v19.4.0 revision, and that seems to break things. I tried adding the npm@18.13.0 command, but it says it can't find that repository.

Thanks, Dan!!

Danp

@JamfoFL I think I figured out the cause, but we will need to wait for @julien-f to confirm.

It seems like the commit info is being embedded in to xo-web package. With the new turborepo addition, xo-web isn't rebuilt each time you rebuild XO, which causes the old commit info to be displayed on the About page. AFAICS, this is benign but still misleading.

JamfoFL

@Danp Aha! Yes, I can see how that would happen.

I just feel better knowing I wasn't doing something stupid or missing the obvious.

Thanks again for looking into that so quickly!

julien-f

@Danp Good catch!

With Turbo, packages are only rebuilt if their code or one of their dependencies changed, which mean it should now be a lot faster to upgrade (especially for xo-web which is very slow to build), but indeed, that makes the commit id displayed in xo-web out-of-date

Don't know what's the best answer for this problem, maybe we should simply remove the commit id displayed on xo-web. Does anyone have opinions on this?

olivierlambert

We need a way to know which is the current commit, to also then (ideally) compare it to the latest one on master. This way, we can be sure people won't report bugs or feature requests before being sure they are up to date. It's very important, otherwise, we'll spend days per year asking people if they are up to date.

So maybe we need a dedicated piece of code doing a check. This is really important.

Danp

@julien-f @olivierlambert Would NodeGit provide the needed functionality?

JamfoFL

@Danp @julien-f @olivierlambert Thanks everyone for looking into this. I'm sorry I kicked over such a hornet's nest.

Just to keep everyone up-to-date, I ran through the process to update the commits this morning and it looks like Turbopro was maybe removed or modified? The process to apply the commits went back to the old length of time it took to complete (maybe about two minutes) and my XO About screen is displaying the most recent commit once again.

Thank you!

julien-f

@JamfoFL No problem, this is an interesting feedback and something we have to improve

No we did not remove Turbo, but it will rebuild everything if you reinstall the dependencies (as the cache is located in node_modules/).

jr-m4

Hi,
Sorry for necroposting here. But just wanted to bump and let y'all know that this is still an issue.
Where right now, the About section will say that I'm on commit 7e66a. With 8 commits behind master 51f95

But doing a (several) full update according to installation instructions in the docs. git show -s, tells me that I'm on

commit 51f95b3c8590492164be38a77ad2c7bf5dc42451

jr-m4

@jr-m4 said in Xen Orchestra has stopped updating commits:

Hi,
Sorry for necroposting here. But just wanted to bump and let y'all know that this is still an issue.
Where right now, the About section will say that I'm on commit 7e66a. With 8 commits behind master 51f95

But doing a (several) full update according to installation instructions in the docs. git show -s, tells me that I'm on
commit 51f95b3c8590492164be38a77ad2c7bf5dc42451

Quick update:
After clearing/deleting the folder node_modules completely along with another upgrade, solved the symptom for me. However, it is quite obvious that the underlying issue isn't fixed.
It might be superfical at first glace. But as @olivierlambert said, it is quite beneficial to know which is the actual commit being used/applied.

Also for completeness sake:
I do my updates through a short script that goes through the commands listed in the official installation docs. Along with me using it as a systemd service

#!/bin/bash
git checkout . &&\
git pull --ff-only &&\
yarn &&\
yarn build &&\
systemctl restart xo-server

olivierlambert

ping @julien-f

julien-f

@jr-m4 You're saying that git no longer updates the repo`?

What's the git pull --ff-only error message?

jr-m4

@julien-f
Hi,

No. I'm saying that sometimes the "About"-section in XO (source version). Doesn't show the actual commit being used. And is instead lagging behind. Even though the acctual code being compile is on the newest commit.
Removing the node_modules folder, cleared this issue. So there is some cache that doesn't always get updated with new commit versions.

olivierlambert

Are you rebuilding and then refreshing xo-web?