Xen Orchestra has stopped updating commits
-
@JamfoFL I think I figured out the cause, but we will need to wait for @julien-f to confirm.
It seems like the commit info is being embedded in to xo-web package. With the new turborepo addition, xo-web isn't rebuilt each time you rebuild XO, which causes the old commit info to be displayed on the About page. AFAICS, this is benign but still misleading.
-
@Danp Aha! Yes, I can see how that would happen.
I just feel better knowing I wasn't doing something stupid or missing the obvious.
Thanks again for looking into that so quickly!
-
@Danp Good catch!
With Turbo, packages are only rebuilt if their code or one of their dependencies changed, which mean it should now be a lot faster to upgrade (especially for xo-web which is very slow to build), but indeed, that makes the commit id displayed in xo-web out-of-date
Don't know what's the best answer for this problem, maybe we should simply remove the commit id displayed on xo-web. Does anyone have opinions on this?
-
We need a way to know which is the current commit, to also then (ideally) compare it to the latest one on
master. This way, we can be sure people won't report bugs or feature requests before being sure they are up to date. It's very important, otherwise, we'll spend days per year asking people if they are up to date.So maybe we need a dedicated piece of code doing a check. This is really important.
-
@julien-f @olivierlambert Would NodeGit provide the needed functionality?
-
@Danp @julien-f @olivierlambert Thanks everyone for looking into this. I'm sorry I kicked over such a hornet's nest.
Just to keep everyone up-to-date, I ran through the process to update the commits this morning and it looks like Turbopro was maybe removed or modified? The process to apply the commits went back to the old length of time it took to complete (maybe about two minutes) and my XO About screen is displaying the most recent commit once again.
Thank you!
-
@JamfoFL No problem, this is an interesting feedback and something we have to improve
No we did not remove Turbo, but it will rebuild everything if you reinstall the dependencies (as the cache is located in
node_modules/). -
Hi,
Sorry for necroposting here. But just wanted to bump and let y'all know that this is still an issue.
Where right now, the About section will say that I'm on commit 7e66a. With 8 commits behind master 51f95But doing a (several) full update according to installation instructions in the docs. git show -s, tells me that I'm on
commit 51f95b3c8590492164be38a77ad2c7bf5dc42451 -
@jr-m4 said in Xen Orchestra has stopped updating commits:
Hi,
Sorry for necroposting here. But just wanted to bump and let y'all know that this is still an issue.
Where right now, the About section will say that I'm on commit 7e66a. With 8 commits behind master 51f95But doing a (several) full update according to installation instructions in the docs. git show -s, tells me that I'm on
commit 51f95b3c8590492164be38a77ad2c7bf5dc42451Quick update:
After clearing/deleting the folder node_modules completely along with another upgrade, solved the symptom for me. However, it is quite obvious that the underlying issue isn't fixed.
It might be superfical at first glace. But as @olivierlambert said, it is quite beneficial to know which is the actual commit being used/applied.Also for completeness sake:
I do my updates through a short script that goes through the commands listed in the official installation docs. Along with me using it as a systemd service#!/bin/bash git checkout . &&\ git pull --ff-only &&\ yarn &&\ yarn build &&\ systemctl restart xo-server -
ping @julien-f
-
@jr-m4 You're saying that
gitno longer updates the repo`?What's the
git pull --ff-onlyerror message? -
@julien-f
Hi,No. I'm saying that sometimes the "About"-section in XO (source version). Doesn't show the actual commit being used. And is instead lagging behind. Even though the acctual code being compile is on the newest commit.
Removing the node_modules folder, cleared this issue. So there is some cache that doesn't always get updated with new commit versions. -
Are you rebuilding and then refreshing xo-web?
-
@olivierlambert
I amUpdate:
Correction.. I run this script I pasted above. That builds the entire code AFAIK. As to what specific portions of the code that acctually get recompile. I do not know. -
It seems like the commit info is being embedded in to xo-web package. With the new turborepo addition, xo-web isn't rebuilt each time you rebuild XO, which causes the old commit info to be displayed on the About page. AFAICS, this is benign but still misleading.
Pretty sure this is still the reason for the discrepancy.
-
@Danp This is exactly that
-
Just a small thing from my side, I know this thread is old, but perhaps it might help someone.
I am also updating my xen-orchestra the same way as @jr-m4 with a script, as per documentation instructions.
I also noted that it kept on saying I was behind a commit in the xen orchestra web interface / about page, however the commit was the latest one.
Changing my script from this:
cd /path/to/xen-orchestra/ git checkout . git pull --ff-only yarn yarn build service orchestra restartto this, note the
yarn build --force:cd /path/to/xen-orchestra/ git checkout . git pull --ff-only yarn yarn build --force service orchestra restartfixed the issue, as it forces a complete rebuild, and it changes the yarn build command to run this (note the force part):
$ TURBO_TELEMETRY_DISABLED=1 turbo run build --filter xo-server --filter xo-server-'*' --filter xo-web --forceinstead of this:
$ TURBO_TELEMETRY_DISABLED=1 turbo run build --filter xo-server --filter xo-server-'*' --filter xo-webThis makes the script run a bit longer, but it's not that big of a deal, and it fixes my xen orchestra web interface to always show the latest version.
-
That happens to me about once every six weeks on one of the XO installs. For what its worth, if I just kill the XO vm and let it reboot, as long as its not out of disk space, it always works the second time.
