Xen Orchestra has stopped updating commits

jr-m4

@jr-m4 said in Xen Orchestra has stopped updating commits:

Hi,
Sorry for necroposting here. But just wanted to bump and let y'all know that this is still an issue.
Where right now, the About section will say that I'm on commit 7e66a. With 8 commits behind master 51f95

But doing a (several) full update according to installation instructions in the docs. git show -s, tells me that I'm on
commit 51f95b3c8590492164be38a77ad2c7bf5dc42451

Quick update:
After clearing/deleting the folder node_modules completely along with another upgrade, solved the symptom for me. However, it is quite obvious that the underlying issue isn't fixed.
It might be superfical at first glace. But as @olivierlambert said, it is quite beneficial to know which is the actual commit being used/applied.

Also for completeness sake:
I do my updates through a short script that goes through the commands listed in the official installation docs. Along with me using it as a systemd service

#!/bin/bash
git checkout . &&\
git pull --ff-only &&\
yarn &&\
yarn build &&\
systemctl restart xo-server

olivierlambert

ping @julien-f

julien-f

@jr-m4 You're saying that git no longer updates the repo`?

What's the git pull --ff-only error message?

jr-m4

@julien-f
Hi,

No. I'm saying that sometimes the "About"-section in XO (source version). Doesn't show the actual commit being used. And is instead lagging behind. Even though the acctual code being compile is on the newest commit.
Removing the node_modules folder, cleared this issue. So there is some cache that doesn't always get updated with new commit versions.

olivierlambert

Are you rebuilding and then refreshing xo-web?

jr-m4

@olivierlambert
I am

Update:
Correction.. I run this script I pasted above. That builds the entire code AFAIK. As to what specific portions of the code that acctually get recompile. I do not know.

Danp

It seems like the commit info is being embedded in to xo-web package. With the new turborepo addition, xo-web isn't rebuilt each time you rebuild XO, which causes the old commit info to be displayed on the About page. AFAICS, this is benign but still misleading.

Pretty sure this is still the reason for the discrepancy.

julien-f

@Danp This is exactly that

janpan

Just a small thing from my side, I know this thread is old, but perhaps it might help someone.

I am also updating my xen-orchestra the same way as @jr-m4 with a script, as per documentation instructions.

I also noted that it kept on saying I was behind a commit in the xen orchestra web interface / about page, however the commit was the latest one.

Changing my script from this:

cd /path/to/xen-orchestra/
git checkout .
git pull --ff-only
yarn
yarn build
service orchestra restart

to this, note the yarn build --force:

cd /path/to/xen-orchestra/
git checkout .
git pull --ff-only
yarn
yarn build --force
service orchestra restart

fixed the issue, as it forces a complete rebuild, and it changes the yarn build command to run this (note the force part):

$ TURBO_TELEMETRY_DISABLED=1 turbo run build --filter xo-server --filter xo-server-'*' --filter xo-web --force

instead of this:

$ TURBO_TELEMETRY_DISABLED=1 turbo run build --filter xo-server --filter xo-server-'*' --filter xo-web

This makes the script run a bit longer, but it's not that big of a deal, and it fixes my xen orchestra web interface to always show the latest version.

archw

That happens to me about once every six weeks on one of the XO installs. For what its worth, if I just kill the XO vm and let it reboot, as long as its not out of disk space, it always works the second time.

ducatijosh

I ran into this issue today after doing the following I was still seeing the old version in the settings -> about

sudo systemctl stop xo-server
git pull --ff-only
yarn
yarn build --force
sudo systemctl start xo-server

I then did a full OS reboot now the commit shows up to date rather than 23 commits behind, why was a reboot needed? Shouldn't restarting the service be enough?

florent

@ducatijosh my bet is that xo-server was still not completly stoppe,d thus was serving the old code . As strange as it seems, it you start a second xo-server, it won't fail, but only show a warningin the logs

a full reboot really restart xo-server

florent

ping @julienxovates I think we can change thie behavior ( accepting a xo-server start even if a zombie process is still running)

julienXOvates

yes we'll enhance this behavior in a coming release ! thanks

ducatijosh

@florent said:

ping @julienxovates I think we can change thie behavior ( accepting a xo-server start even if a zombie process is still running)

Hello, Today I tried to update again with the same steps and a reboot and it still shows out of date.

I did see the new XO6 features so I assume it kind of half worked

From the command line I ran
git log -1 --format="%h"
and still saw the old commit version of c998f though

I then ran the following and got the newest 7e144 version
git fetch --all
git reset --hard origin/master

From there I reran my yarn and yarn build commands and it's updated fully now.
For some reason git pull --ff-only was not getting the full update or something.

pierrebrunet

@ducatijosh Hi,
Can you check git status to see if you have anything tracked in your repository? You need to wait for a new commit in master though.

ducatijosh

@pierrebrunet

It says the following when I run that:

On branch master
Your branch is up to date with 'origin/master'.
no changes added to commit

florent

@ducatijosh did you do a yarn build ?