Health Checks Failing

[Delgado]

Hello,

It looks like my health checks have recently started failing with the following error. val is not a non-empty string or a valid number. val=undefined. I am on commit 16498 and this error seems to happen at least on continuous replication and delta jobs as those are the backup types i am using. One of my logs is pasted below.

  "data": {
    "mode": "delta",
    "reportWhen": "always"
  },
  "id": "1713396711992",
  "jobId": "1da6d60a-9597-48e6-a0ea-83e9fc82c523",
  "jobName": "Continuous Replication",
  "message": "backup",
  "scheduleId": "959861e5-c53a-4c04-8ca8-1b017a3010d2",
  "start": 1713396711992,
  "status": "failure",
  "infos": [
    {
      "data": {
        "vms": [
          "42e5c2a7-8c84-cfc3-efb8-c897e8971222"
        ]
      },
      "message": "vms"
    }
  ],
  "tasks": [
    {
      "data": {
        "type": "VM",
        "id": "42e5c2a7-8c84-cfc3-efb8-c897e8971222",
        "name_label": "Tang"
      },
      "id": "1713396717519",
      "message": "backup VM",
      "start": 1713396717519,
      "status": "failure",
      "tasks": [
        {
          "id": "1713396717692",
          "message": "snapshot",
          "start": 1713396717692,
          "status": "success",
          "end": 1713396722930,
          "result": "6c31c9cc-1c1a-f040-9ed9-08d8f4c5b954"
        },
        {
          "data": {
            "id": "889ed0fc-0825-8c3e-dde4-229139a008f7",
            "isFull": false,
            "name_label": "Replication",
            "type": "SR"
          },
          "id": "1713396722936",
          "message": "export",
          "start": 1713396722936,
          "status": "failure",
          "tasks": [
            {
              "id": "1713396730781",
              "message": "transfer",
              "start": 1713396730781,
              "status": "success",
              "end": 1713396948009,
              "result": {
                "size": 144772096
              }
            },
            {
              "id": "1713396950509",
              "message": "health check",
              "start": 1713396950509,
              "status": "failure",
              "tasks": [
                {
                  "id": "1713396950630",
                  "message": "cloning-vm",
                  "start": 1713396950630,
                  "status": "success",
                  "end": 1713396953455,
                  "result": "OpaqueRef:e0eda8c6-53ff-7af4-29d9-154674e1cf15"
                }
              ],
              "end": 1713396954808,
              "result": {
                "message": "val is not a non-empty string or a valid number. val=undefined",
                "name": "Error",
                "stack": "Error: val is not a non-empty string or a valid number. val=undefined\n    at module.exports (/opt/xo/xo-builds/xen-orchestra-202404171500/node_modules/ms/index.js:34:9)\n    at file:///opt/xo/xo-builds/xen-orchestra-202404171500/@xen-orchestra/backups/_runners/_writers/_MixinXapiWriter.mjs:74:29\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
              }
            }
          ],
          "end": 1713396954808,
          "result": {
            "message": "val is not a non-empty string or a valid number. val=undefined",
            "name": "Error",
            "stack": "Error: val is not a non-empty string or a valid number. val=undefined\n    at module.exports (/opt/xo/xo-builds/xen-orchestra-202404171500/node_modules/ms/index.js:34:9)\n    at file:///opt/xo/xo-builds/xen-orchestra-202404171500/@xen-orchestra/backups/_runners/_writers/_MixinXapiWriter.mjs:74:29\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
          }
        }
      ],
      "infos": [
        {
          "message": "Transfer data using NBD"
        }
      ],
      "end": 1713396954811,
      "result": {
        "message": "val is not a non-empty string or a valid number. val=undefined",
        "name": "Error",
        "stack": "Error: val is not a non-empty string or a valid number. val=undefined\n    at module.exports (/opt/xo/xo-builds/xen-orchestra-202404171500/node_modules/ms/index.js:34:9)\n    at file:///opt/xo/xo-builds/xen-orchestra-202404171500/@xen-orchestra/backups/_runners/_writers/_MixinXapiWriter.mjs:74:29\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
      }
    }
  ],
  "end": 1713396954811
}

I don't belive I am missing any requirements in my backup jobs I went back and double checked. Please let me know if I need to provide anymore information. Thanks again for a great product!

[julien-f]

Thanks for the report, it should be fixed, let us know if that's not the case

https://github.com/vatesfr/xen-orchestra/commit/aa6b23c06cf2056600cdabaaa1705ab1067ed2a9

0 fbeauchamp committed to vatesfr/xen-orchestra

fix(backups): use the right settings in writers (#7567)

Fixes https://xcp-ng.org/forum/post/75762
Introduced by 42dc75e7398c558e0ed850d94aafae9f88c615db

Fix error `Error: val is not a non-empty string or a valid number. val=undefined`

[Danp]

What version of Node are you running?

[Delgado]

Hey @Danp it looks like I am running v18.17.1 the os is Rocky Linux 9 if that matters at all.

[olivierlambert]

Pinging @julien-f in case val is not a non-empty string or a valid number. val=undefined rings a bell

[florent]

@Delgado said in Health Checks Failing:

_MixinXapiWriter

Hi,
This is probably linked to the PR that makes healthcheck timeout configurable, I am looking into it right now

Regards

[julien-f]

Thanks for the report, it should be fixed, let us know if that's not the case

https://github.com/vatesfr/xen-orchestra/commit/aa6b23c06cf2056600cdabaaa1705ab1067ed2a9

0 fbeauchamp committed to vatesfr/xen-orchestra

fix(backups): use the right settings in writers (#7567)

Fixes https://xcp-ng.org/forum/post/75762
Introduced by 42dc75e7398c558e0ed850d94aafae9f88c615db

Fix error `Error: val is not a non-empty string or a valid number. val=undefined`

[Delgado]

@florent can confirm that health checks are working again! Thanks for the prompt reply!

[florent]

@Delgado said in Health Checks Failing:

@florent can confirm that health checks are working again! Thanks for the prompt reply!

thanks for the precise bug report, that is half of the job done