XCP-ng
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Groups
    • Register
    • Login

    Snapshots are no longer being pruned? Commit 58f02

    Scheduled Pinned Locked Moved Backup
    7 Posts 3 Posters 86 Views 4 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • P Offline
      probain
      last edited by probain

      Running XO from source - Commit 58f02 on a fully update XCP-NG 8.3
      Since Friday (error might have come silently from earlier), snapshots are no longer being pruned. After week-end, when I got a possibility to look at what was/is happening. I had 109 snapshots for each VM. The retention is 4.

      • I've tried to delete the old schedule and re-create it.
      • I've tried to delete the backup-job, and re-create it.
      • I've tried adjusting the retetion

      None of the above have had any discernable affect.

      Is there something else I can do or provide, to maybe hammer out this? Since I belive it to be a bug. I would very much want to do my part in finding the solution.

      Thanks!

      P 1 Reply Last reply Reply Quote 0
      • P Offline
        probain @probain
        last edited by probain

        Trying to pin down a "known good" at the moment.

        Update:
        ~~Found one: a101e

        I'll try to step through the commits, to find where it breaks.~~

        Update 2: a101e might not be a "known good".

        A 1 Reply Last reply Reply Quote 0
        • A AlexD2006 referenced this topic
        • A Offline
          AlexD2006 @probain
          last edited by

          @probain
          I have a similar, even not the same Problem right now.
          Maybe there is the same root-cause, so im linkin it here.
          https://xcp-ng.org/forum/topic/11540/continuous-replication-isnt-deleting-old-replikas-anymore-since-update

          Kind Regards
          Alex

          1 Reply Last reply Reply Quote 1
          • P Offline
            probain
            last edited by

            It might be that my known good, isn't that good at all.

            I can replicate the problem in my second lab as well. But it is being affected even with commits older than a101e.
            I'm still trying to find and provide better/useful information.

            1 Reply Last reply Reply Quote 0
            • P Offline
              probain
              last edited by

              @AlexD2006

              Thanks for your input.

              So I believe I've managed to find which commit breaks my snapshot-pruning.

              If I use the commit: 8a390057b648205b7ae2c6ccc2a0bc78dc624e08 - Then the pruning works.

              However, if I go to the next one: 05c6f87a1212e81c51e63f6a585b9e97a3c1bfb2- Pruning breaks and snapshots are no longer being deleted as retention says they should.

              I can consistently and reliably re-create the different scenarios in my first lab. This doesn't explain why I'm seing inconsistent results in my other lab. But that might be user error, that I have to double check tomorrow!

              Perhaps you could try to see if you see the same behaviour between the commits?

              1 Reply Last reply Reply Quote 0
              • olivierlambertO Offline
                olivierlambert Vates 🪐 Co-Founder CEO
                last edited by

                That's a very good feedback, I will tell the team internally. Pinging also @florent and @Bastien-Nollet in the mean time.

                1 Reply Last reply Reply Quote 1
                • olivierlambertO Offline
                  olivierlambert Vates 🪐 Co-Founder CEO
                  last edited by

                  @probain said in Snapshots are no longer being pruned? Commit 58f02:

                  05c6f87a1212e81c51e63f6a585b9e97a3c1bfb2

                  This commit is https://github.com/vatesfr/xen-orchestra/commit/05c6f87a1212e81c51e63f6a585b9e97a3c1bfb2

                  It's related to retention, so that would explain the issue if there's a bug in there.

                  0 fbeauchamp committed to vatesfr/xen-orchestra
                  fix(backups): long term retention taking the most recent values (#9180)
                  1 Reply Last reply Reply Quote 1
                  • First post
                    Last post