Snapshots are no longer being pruned? Commit 58f02
-
Trying to pin down a "known good" at the moment.
Update:
~~Found one: a101eI'll try to step through the commits, to find where it breaks.~~
Update 2: a101e might not be a "known good".
-
A AlexD2006 referenced this topic on
-
@probain
I have a similar, even not the same Problem right now.
Maybe there is the same root-cause, so im linkin it here.
https://xcp-ng.org/forum/topic/11540/continuous-replication-isnt-deleting-old-replikas-anymore-since-updateKind Regards
Alex -
It might be that my known good, isn't that good at all.
I can replicate the problem in my second lab as well. But it is being affected even with commits older than a101e.
I'm still trying to find and provide better/useful information. -
Thanks for your input.
So I believe I've managed to find which commit breaks my snapshot-pruning.
If I use the commit: 8a390057b648205b7ae2c6ccc2a0bc78dc624e08 - Then the pruning works.
However, if I go to the next one: 05c6f87a1212e81c51e63f6a585b9e97a3c1bfb2- Pruning breaks and snapshots are no longer being deleted as retention says they should.
I can consistently and reliably re-create the different scenarios in my first lab. This doesn't explain why I'm seing inconsistent results in my other lab. But that might be user error, that I have to double check tomorrow!
Perhaps you could try to see if you see the same behaviour between the commits?
-
That's a very good feedback, I will tell the team internally. Pinging also @florent and @Bastien-Nollet in the mean time.
-
@probain said in Snapshots are no longer being pruned? Commit 58f02:
05c6f87a1212e81c51e63f6a585b9e97a3c1bfb2
This commit is https://github.com/vatesfr/xen-orchestra/commit/05c6f87a1212e81c51e63f6a585b9e97a3c1bfb2
It's related to retention, so that would explain the issue if there's a bug in there.
-
I can now reliably recreate the behavior between the commits mentioned above.
As I expected, the problems with finding a "known good" was due to user error -
@probain thanks for signaling this, we just merged a fix, that fix it on our labs
can you test it on your side ?
https://github.com/vatesfr/xen-orchestra/pull/9202 -
@florent said in Snapshots are no longer being pruned? Commit 58f02:
@probain thanks for signaling this, we just merged a fix, that fix it on our labs
can you test it on your side ?
https://github.com/vatesfr/xen-orchestra/pull/9202I can confirm that it solves the issue in my primary lab. Tomorrow I will be able to re-validate at my second lab as well.
Thank you for such a quick fix! -
Thanks everyone for the precise feedback, it was really helpful! And thanks @florent for the fix
-
For completeness sake. Confirming that the fix also works in my second lab as well.
-
O olivierlambert marked this topic as a question on
-
O olivierlambert has marked this topic as solved on
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login