Mirror backup broken since XO 6.3.0 release, "Error: Cannot read properties of undefined (reading 'id')"

[MajorP93]

Hello Vates and XCP-ng community,

I have updated my Xen Orchestra from sources VM and want to report that after updating my mirror backup job does not work anymore. I updated to commit 875ceb7cab9735efc29c345603a4280cb6072fbc (feat: release XO 6.3.1).

Prior to updating XO it has been working fine for weeks. I did not change anything about it's config.

I get "Error: Cannot read properties of undefined (reading 'id')" for each any every VM that the mirror job tries to mirror.

It is a "mirror incremental" backup job.

Is this a known issue?
Did anyone else encounter this?

If a XO developer needs logs, I can provide them in a private message as I am not sure if they contain sensitive information in this case.

My XO VM is running on Debian 13 and Node 22 by the way.

Thanks and best regards

[Danp]

Hi,

Thanks for the report. I'm checking with the XOA team to see if this is a known issue.

Regards, Dan

[Pilow]

@Danp just upgraded XOA from 6.1.2 to 6.3.1
same error

        {
          "data": {
            "id": "bc54f9a7-ca66-4c7c-9c35-c37a715af458",
            "type": "remote"
          },
          "id": "1775058349205",
          "message": "export",
          "start": 1775058349205,
          "status": "failure",
          "end": 1775058349205,
          "result": {
            "message": "Cannot read properties of undefined (reading 'id')",
            "name": "TypeError",
            "stack": "TypeError: Cannot read properties of undefined (reading 'id')\n    at IncrementalRemoteWriter._prepare (file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/_runners/_writers/IncrementalRemoteWriter.mjs:93:39)\n    at file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/_runners/_writers/IncrementalRemoteWriter.mjs:87:32\n    at file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/Task.mjs:108:24\n    at Zone.run (/usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/node-zone/index.js:80:23)\n    at Task.run (file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/Task.mjs:106:23)\n    at IncrementalRemoteWriter.prepare (file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/_runners/_writers/IncrementalRemoteWriter.mjs:87:17)\n    at file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/_runners/_vmRunners/IncrementalRemote.mjs:92:48\n    at callWriter (file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/_runners/_vmRunners/_Abstract.mjs:33:15)\n    at IncrementalRemoteVmBackupRunner._callWriters (file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/_runners/_vmRunners/_Abstract.mjs:52:14)\n    at IncrementalRemoteVmBackupRunner._run (file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/_runners/_vmRunners/IncrementalRemote.mjs:92:18)"
          }
        }
      ],
      "end": 1775058349208,
      "result": {
        "message": "Cannot read properties of undefined (reading 'id')",
        "name": "TypeError",
        "stack": "TypeError: Cannot read properties of undefined (reading 'id')\n    at IncrementalRemoteWriter._prepare (file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/_runners/_writers/IncrementalRemoteWriter.mjs:93:39)\n    at file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/_runners/_writers/IncrementalRemoteWriter.mjs:87:32\n    at file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/Task.mjs:108:24\n    at Zone.run (/usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/node-zone/index.js:80:23)\n    at Task.run (file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/Task.mjs:106:23)\n    at IncrementalRemoteWriter.prepare (file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/_runners/_writers/IncrementalRemoteWriter.mjs:87:17)\n    at file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/_runners/_vmRunners/IncrementalRemote.mjs:92:48\n    at callWriter (file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/_runners/_vmRunners/_Abstract.mjs:33:15)\n    at IncrementalRemoteVmBackupRunner._callWriters (file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/_runners/_vmRunners/_Abstract.mjs:52:14)\n    at IncrementalRemoteVmBackupRunner._run (file:///usr/local/lib/node_modules/@xen-orchestra/proxy/node_modules/@xen-orchestra/backups/_runners/_vmRunners/IncrementalRemote.mjs:92:18)"
      }
    },

[florent]

@Pilow said:

(file:///usr/local/lib/node_modules/@x

fix is here https://github.com/vatesfr/xen-orchestra/pull/9667

fbeauchamp opened this pull request in vatesfr/xen-orchestra

open fix(backups): schedule reference is missing #9667

[Pilow]

@florent made the modification and restarted the xo-server

but still have the problem

[22:13 01] xoa:_vmRunners$ cat _AbstractRemote.mjs|grep -B5 -A 5 schedule
  constructor({
    config,
    job,
    healthCheckSr,
    remoteAdapters,
    schedule,
    settings,
    sourceRemoteAdapter,
    throttleGenerator,
    throttleStream,
    vmUuid,
--
    super()
    this.config = config
    this.job = job
    this.remoteAdapters = remoteAdapters
    this._settings = settings
    this.scheduleId = schedule.id
    this.timestamp = undefined

    this._healthCheckSr = healthCheckSr
    this._sourceRemoteAdapter = sourceRemoteAdapter
    this._throttleGenerator = throttleGenerator
--
          adapters: remoteAdapters,
          BackupWriter,
          config,
          healthCheckSr,
          job,
          schedule,
          vmUuid,
          settings,
        })
      )
    } else {
--
          new BackupWriter({
            adapter,
            config,
            healthCheckSr,
            job,
            schedule,
            vmUuid,
            remoteId,
            settings: targetSettings,
          })
        )
[22:13 01] xoa:_vmRunners$

need to modify anything else ? I noticed only 2 line modifications in #9667

[Pilow]

tried either by manual run, or relaunched the schedule to see if context of schedule was needed to get id of the schedule, but to no avail

schedule or schedule.id seems to be undefined